Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to the Comm Interface #1048

Closed
wants to merge 7 commits into from

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 added the bug label Dec 7, 2022
@maartenbreddels
Copy link
Contributor

@blink1073 what's the issue with the comm this time? do you have a link to an issue?
do the test (your last commit) fail on main now?

@blink1073
Copy link
Member Author

#1040 (comment)

@blink1073
Copy link
Member Author

The tests pass but the dynamic behavior of widgets wasn't working.

@blink1073
Copy link
Member Author

Closing in favor of #1049

@blink1073 blink1073 deleted the revert-comm-changes branch December 7, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants