Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version break IPyWidgets #1043

Closed
DonJayamanne opened this issue Nov 30, 2022 · 4 comments · Fixed by #1049
Closed

Latest version break IPyWidgets #1043

DonJayamanne opened this issue Nov 30, 2022 · 4 comments · Fixed by #1049
Labels

Comments

@DonJayamanne
Copy link

IPyKernel Version: 6.18.3
Install Jupyter and ipywidgets
Run a notebook with the following code

  • Cell 1
from ipywidgets import FloatSlider, IntSlider, Image, IntText, link

slider = IntSlider(description="Continuous Slider", continuous_update=True)
textbox = IntText(description="Continuous Text", continuous_update=True)

link((slider, 'value'), (textbox, 'value'))
  • Cell 2
slider
  • Cell 3
textbox

Drag the slider and the value in the textbox should change

Now: Install ipykernel==6.17.1 (previous version)
Test the same code and the value in the textbox will end up getting updated.

@blink1073
Copy link
Member

Yanked. @martinRenou I'm inclined to completely back out these comm changes, I don't know how we can do this in a backward-compatible way.

@blink1073 blink1073 added the bug label Nov 30, 2022
@DonJayamanne
Copy link
Author

DonJayamanne commented Nov 30, 2022

thanks for addressing this quickly

Since that version has been pull out, please feel free to close this issue.
I'd close it, though I'm unsure whether you'd use this to track some breakage in that version/main branch before pushing the next version

@blink1073
Copy link
Member

Thanks @DonJayamanne, let's leave this open for discussion.

@maartenbreddels
Copy link
Contributor

Let me take a look if I can add a test case that covers this, @blink1073 you didn't expose this in the test of #1048 yet right?

blink1073 pushed a commit that referenced this issue Dec 7, 2022
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
Fixes #1043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants