New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurables needs to be configurable #1037
Merged
blink1073
merged 9 commits into
ipython:main
from
Carreau:configurables-aught-to-be-configurables
Nov 29, 2022
Merged
Configurables needs to be configurable #1037
blink1073
merged 9 commits into
ipython:main
from
Carreau:configurables-aught-to-be-configurables
Nov 29, 2022
Commits on Nov 28, 2022
-
Configurables needs to be configurable.
IPython rely on configurables being configurables to ... configure things. Comm seem to insert or return a non-configurable in IPython, that make ipykernel crash in some instances. For example but not limited to: %config Completer.use_jedi = False Or trying to use hvplot for example. This is just a "this is wrong" PR, there should be a proper fix, and I will likely add a hard check in IPython that what is added in configurables is actually a configurables. This will need a fix in a Comm pacakge.
Configuration menu - View commit details
-
Copy full SHA for fcf565f - Browse repository at this point
Copy the full SHA fcf565fView commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 17f3c83 - Browse repository at this point
Copy the full SHA 17f3c83View commit details
Commits on Nov 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ff69932 - Browse repository at this point
Copy the full SHA ff69932View commit details -
Configuration menu - View commit details
-
Copy full SHA for b55eede - Browse repository at this point
Copy the full SHA b55eedeView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd39dc5 - Browse repository at this point
Copy the full SHA cd39dc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae2dedd - Browse repository at this point
Copy the full SHA ae2deddView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6482fe - Browse repository at this point
Copy the full SHA c6482feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4606a77 - Browse repository at this point
Copy the full SHA 4606a77View commit details -
Configuration menu - View commit details
-
Copy full SHA for c53280c - Browse repository at this point
Copy the full SHA c53280cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.