Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurables needs to be configurable #1037

Merged

Commits on Nov 28, 2022

  1. Configurables needs to be configurable.

    IPython rely on configurables being configurables to ... configure
    things.
    
    Comm seem to insert or return a non-configurable in IPython, that make
    ipykernel crash in some instances. For example but not limited to:
    
        %config Completer.use_jedi = False
    
    Or trying to use hvplot for example.
    
    This is just a "this is wrong" PR, there should be a proper fix,
    and I will likely add a hard check in IPython that what is added in
    configurables is actually a configurables.
    
    This will need a fix in a Comm pacakge.
    Carreau committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    fcf565f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17f3c83 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. override create_manager

    blink1073 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ff69932 View commit details
    Browse the repository at this point in the history
  2. add import

    blink1073 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b55eede View commit details
    Browse the repository at this point in the history
  3. fix import

    blink1073 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    cd39dc5 View commit details
    Browse the repository at this point in the history
  4. fix imports

    blink1073 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ae2dedd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c6482fe View commit details
    Browse the repository at this point in the history
  6. fix test

    blink1073 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    4606a77 View commit details
    Browse the repository at this point in the history
  7. fix override name

    blink1073 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    c53280c View commit details
    Browse the repository at this point in the history