Configurables needs to be configurable #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPython rely on configurables being configurables to ... configure
things.
Comm seem to insert or return a non-configurable in IPython, that make
ipykernel crash in some instances. For example but not limited to:
%config Completer.use_jedi = False
Or trying to use hvplot for example.
This is just a "this is wrong" PR, there should be a proper fix,
and I will likely add a hard check in IPython that what is added in
configurables is actually a configurables.
This will need a fix in a Comm pacakge.
|
cc @fperez |
for more information, see https://pre-commit.ci
weiji14
pushed a commit
to CryoInTheCloud/hub-image
that referenced
this pull request
Nov 28, 2022
…#8) - Adds boto3 and holoviews-related tools used by the ICESat-2 tutorial. - Pins ipykernel to 6.16.0 until ipython/ipykernel#1037 is resolved - Reconciles environment name with the one on the main site repo, we'll use `cryocloud` for the env name henceforth
blink1073
changed the title
|
Thanks for the report! I'll make a new release with this tomorrow. |
|
Thx a lot @blink1073!! cc @yuvipanda @tsnow03 @weiji14 - we might be able to release the ipykernel pin on our cryo env soon. |
|
I already yanked the offending version, you should be able to remove the pin now |
|
Ah, got it, thx! |
|
Looks like |
blink1073
added a commit
to blink1073/ipykernel
that referenced
this pull request
Dec 7, 2022
This reverts commit a38167b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPython rely on configurables being configurables to ... configure things.
Comm seem to insert or return a non-configurable in IPython, that make ipykernel crash in some instances. For example but not limited to:
Or trying to use hvplot for example.
This is just a "this is wrong" PR, there should be a proper fix, and I will likely add a hard check in IPython that what is added in configurables is actually a configurables.
This will need a fix in a Comm pacakge.