Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPods swap promise.all for reduce to avoid git locking problem #2169

Merged
merged 1 commit into from Mar 17, 2022

Conversation

hborawski
Copy link
Collaborator

@hborawski hborawski commented Mar 16, 2022

What Changed

Changed Promise.all to a reduce into a chain

Why

Running git checkout in parallel can cause a git error if the processes try to get the lock at the same time

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.2169.25725.gz
auto-macos--canary.2169.25725.gz
auto-win.exe--canary.2169.25725.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.34.2--canary.2169.25725.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.34.2--canary.2169.25725.0
npm install @auto-canary/auto@10.34.2--canary.2169.25725.0
npm install @auto-canary/core@10.34.2--canary.2169.25725.0
npm install @auto-canary/package-json-utils@10.34.2--canary.2169.25725.0
npm install @auto-canary/all-contributors@10.34.2--canary.2169.25725.0
npm install @auto-canary/brew@10.34.2--canary.2169.25725.0
npm install @auto-canary/chrome@10.34.2--canary.2169.25725.0
npm install @auto-canary/cocoapods@10.34.2--canary.2169.25725.0
npm install @auto-canary/conventional-commits@10.34.2--canary.2169.25725.0
npm install @auto-canary/crates@10.34.2--canary.2169.25725.0
npm install @auto-canary/docker@10.34.2--canary.2169.25725.0
npm install @auto-canary/exec@10.34.2--canary.2169.25725.0
npm install @auto-canary/first-time-contributor@10.34.2--canary.2169.25725.0
npm install @auto-canary/gem@10.34.2--canary.2169.25725.0
npm install @auto-canary/gh-pages@10.34.2--canary.2169.25725.0
npm install @auto-canary/git-tag@10.34.2--canary.2169.25725.0
npm install @auto-canary/gradle@10.34.2--canary.2169.25725.0
npm install @auto-canary/jira@10.34.2--canary.2169.25725.0
npm install @auto-canary/magic-zero@10.34.2--canary.2169.25725.0
npm install @auto-canary/maven@10.34.2--canary.2169.25725.0
npm install @auto-canary/microsoft-teams@10.34.2--canary.2169.25725.0
npm install @auto-canary/npm@10.34.2--canary.2169.25725.0
npm install @auto-canary/omit-commits@10.34.2--canary.2169.25725.0
npm install @auto-canary/omit-release-notes@10.34.2--canary.2169.25725.0
npm install @auto-canary/pr-body-labels@10.34.2--canary.2169.25725.0
npm install @auto-canary/released@10.34.2--canary.2169.25725.0
npm install @auto-canary/s3@10.34.2--canary.2169.25725.0
npm install @auto-canary/sbt@10.34.2--canary.2169.25725.0
npm install @auto-canary/slack@10.34.2--canary.2169.25725.0
npm install @auto-canary/twitter@10.34.2--canary.2169.25725.0
npm install @auto-canary/upload-assets@10.34.2--canary.2169.25725.0
npm install @auto-canary/vscode@10.34.2--canary.2169.25725.0
# or 
yarn add @auto-canary/bot-list@10.34.2--canary.2169.25725.0
yarn add @auto-canary/auto@10.34.2--canary.2169.25725.0
yarn add @auto-canary/core@10.34.2--canary.2169.25725.0
yarn add @auto-canary/package-json-utils@10.34.2--canary.2169.25725.0
yarn add @auto-canary/all-contributors@10.34.2--canary.2169.25725.0
yarn add @auto-canary/brew@10.34.2--canary.2169.25725.0
yarn add @auto-canary/chrome@10.34.2--canary.2169.25725.0
yarn add @auto-canary/cocoapods@10.34.2--canary.2169.25725.0
yarn add @auto-canary/conventional-commits@10.34.2--canary.2169.25725.0
yarn add @auto-canary/crates@10.34.2--canary.2169.25725.0
yarn add @auto-canary/docker@10.34.2--canary.2169.25725.0
yarn add @auto-canary/exec@10.34.2--canary.2169.25725.0
yarn add @auto-canary/first-time-contributor@10.34.2--canary.2169.25725.0
yarn add @auto-canary/gem@10.34.2--canary.2169.25725.0
yarn add @auto-canary/gh-pages@10.34.2--canary.2169.25725.0
yarn add @auto-canary/git-tag@10.34.2--canary.2169.25725.0
yarn add @auto-canary/gradle@10.34.2--canary.2169.25725.0
yarn add @auto-canary/jira@10.34.2--canary.2169.25725.0
yarn add @auto-canary/magic-zero@10.34.2--canary.2169.25725.0
yarn add @auto-canary/maven@10.34.2--canary.2169.25725.0
yarn add @auto-canary/microsoft-teams@10.34.2--canary.2169.25725.0
yarn add @auto-canary/npm@10.34.2--canary.2169.25725.0
yarn add @auto-canary/omit-commits@10.34.2--canary.2169.25725.0
yarn add @auto-canary/omit-release-notes@10.34.2--canary.2169.25725.0
yarn add @auto-canary/pr-body-labels@10.34.2--canary.2169.25725.0
yarn add @auto-canary/released@10.34.2--canary.2169.25725.0
yarn add @auto-canary/s3@10.34.2--canary.2169.25725.0
yarn add @auto-canary/sbt@10.34.2--canary.2169.25725.0
yarn add @auto-canary/slack@10.34.2--canary.2169.25725.0
yarn add @auto-canary/twitter@10.34.2--canary.2169.25725.0
yarn add @auto-canary/upload-assets@10.34.2--canary.2169.25725.0
yarn add @auto-canary/vscode@10.34.2--canary.2169.25725.0

@intuit-svc intuit-svc added the patch Increment the patch version when merged label Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2169 (1ae8beb) into main (53a8de8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   80.31%   80.31%           
=======================================
  Files          66       66           
  Lines        5420     5421    +1     
  Branches     1269     1269           
=======================================
+ Hits         4353     4354    +1     
  Misses        707      707           
  Partials      360      360           
Impacted Files Coverage Δ
plugins/cocoapods/src/index.ts 89.02% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd6684...1ae8beb. Read the comment docs.

@hborawski hborawski merged commit 5a3ce45 into intuit:main Mar 17, 2022
@hborawski hborawski deleted the cocoapods-multi-podspec branch March 17, 2022 16:34
@intuit-svc
Copy link

🚀 PR was released in v10.34.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants