Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CocoaPods] switch Promise.all for reduce to avoid git lock #2328

Closed
wants to merge 1 commit into from

Conversation

hborawski
Copy link
Collaborator

@hborawski hborawski commented Feb 14, 2023

redo of #2327 because fork build was not working right

What Changed

Switched Promise.all to a reduce a promise chain to avoid git lock

I had done this before for the publish hook but not for the next hook

Why

git lock can be a race condition and sometimes next publish will fail

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

馃悿 Download canary assets:

auto-linux--canary.2328.9694a60d57e4c2d92b424dd32af7dfbbd99ca6cf.gz
auto-macos--canary.2328.9694a60d57e4c2d92b424dd32af7dfbbd99ca6cf.gz
auto-win.exe--canary.2328.9694a60d57e4c2d92b424dd32af7dfbbd99ca6cf.gz

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #2328 (7077adc) into main (5d9dd37) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
- Coverage   80.67%   80.60%   -0.07%     
==========================================
  Files          69       69              
  Lines        5660     5662       +2     
  Branches     1329     1329              
==========================================
- Hits         4566     4564       -2     
- Misses        716      717       +1     
- Partials      378      381       +3     
Impacted Files Coverage 螖
plugins/cocoapods/src/index.ts 88.62% <100.00%> (+0.13%) 猬嗭笍
plugins/microsoft-teams/src/index.ts 81.81% <0.00%> (-3.64%) 猬囷笍
plugins/slack/src/index.ts 77.71% <0.00%> (-1.81%) 猬囷笍
packages/core/src/git.ts 87.05% <0.00%> (+0.27%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hborawski
Copy link
Collaborator Author

looks like the fork wasnt the problem

@hborawski hborawski closed this Feb 14, 2023
@hborawski hborawski deleted the serial-next-cocoapods branch February 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant