Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]: Fixes parsing for checks with : in the name. #1939

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[fix]: Fixes parsing for checks with : in the name. #1939

merged 2 commits into from
Oct 12, 2023

Conversation

yorik
Copy link
Contributor

@yorik yorik commented Oct 5, 2023 •
edited

Resolves #1531

Before the change?

  • Checks with : in the name were not possible to use because the string was split by the first :.

After the change?

  • The string is split by the last :, so it's possible to have check names with : charater.
  • Founds the last : in a check string and uses all after it as app_id.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@yorik
Fixes checks parsing to all checks with : in the name.
5fa6c3b 
Founds the last `:` in a check string and uses all after it as app_id.
@yorik yorik mentioned this pull request Oct 9, 2023
Closed
@nickfloyd nickfloyd added Type: Bug Something isn't working as documented hacktoberfest Issues for participation in Hacktoberfest labels Oct 11, 2023
nickfloyd
nickfloyd approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorik Thank you for the contributions! ❤️

@nickfloyd nickfloyd changed the title Fixes parsing for checks with : in the name. [fix]: Fixes parsing for checks with : in the name. Oct 12, 2023
@nickfloyd nickfloyd merged commit fc5b047 into integrations:main Oct 12, 2023
3 checks passed
@yorik yorik deleted the fix-checks-app-id branch January 18, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
hacktoberfest Issues for participation in Hacktoberfest Type: Bug Something isn't working as documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] github_branch_protection_v3 checks does not allow for colons
2 participants
@yorik @nickfloyd