Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] github_branch_protection_v3 checks does not allow for colons #1531

Closed
mbarany opened this issue Feb 5, 2023 · 2 comments · Fixed by #1939
Closed

[BUG] github_branch_protection_v3 checks does not allow for colons #1531

mbarany opened this issue Feb 5, 2023 · 2 comments · Fixed by #1939
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Breaking change Used to note any change that requires a major version bump Type: Bug Something isn't working as documented

Comments

@mbarany
Copy link
Contributor

mbarany commented Feb 5, 2023

If my status check context includes a colon then it fails.
Our CircleCi jobs for example ci/circleci: unit_test produces the following error:

Error: Could not parse unit_test:-1 as valid app_id

Potential solutions are:

  • Use a different different character to split the string
  • Separate out the context and app_id as separate input variables (e.g. checks = [ { context = "ci/circleci: unit_test", app_id = 1234 } ]

Link to original "checks" feature PR

@kfcampbell kfcampbell added Type: Bug Something isn't working as documented Status: Up for grabs Issues that are ready to be worked on by anyone Type: Breaking change Used to note any change that requires a major version bump Priority: Normal labels Feb 18, 2023
@nickfloyd nickfloyd added the hacktoberfest Issues for participation in Hacktoberfest label Sep 20, 2023
@nickschuch
Copy link

For those looking for a workaround.....

It's not great :D

Revert back to using the depreciated contexts field.

@yorik
Copy link
Contributor

yorik commented Oct 9, 2023

I've created #1939 which should help with the issue without introducing breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues for participation in Hacktoberfest Status: Up for grabs Issues that are ready to be worked on by anyone Type: Breaking change Used to note any change that requires a major version bump Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants