Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: this is what broke everything #570

Merged
merged 1 commit into from May 5, 2021
Merged

fix: this is what broke everything #570

merged 1 commit into from May 5, 2021

Commits on May 5, 2021

  1. fix: this will fix the null > 0 change 

     we found an issue when we upgraded multiple giraffe libraries. This resulted in our graphs intermittently coming back empty/blank. This was because we had originally believed the null values would return 0, as d3-scale did originally. But by upgrading this broke and we were receiving NaN values. These values made it so our graphs could not be displayed properly but only broke on graphs with undefined values.
    @zoesteinkamp
    zoesteinkamp committed May 5, 2021
    Configuration menu
    Copy the full SHA
    39cb697 View commit details
    Browse the repository at this point in the history