fix: this is what broke everything #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
suggested changes
May 5, 2021
There was a problem hiding this comment.
I got a chuckle out of the cheeky commit message, but let's think of posterity on this one. Describe with a little more detail what this fix is - it's funny now, I'll give you that, but in six months, I doubt we'll remember what 'everything' included when we 'broke everything'
Put it in your own style, but if it was me, I'd make this message something like:
fix: force coercion of falsy values to 0
guards against https://github.com/d3/d3-scale/releases/tag/v3.2.4it gives a quick tldr in the first line, and then provides context by linking to the release in the detail part of the message
we found an issue when we upgraded multiple giraffe libraries. This resulted in our graphs intermittently coming back empty/blank. This was because we had originally believed the null values would return 0, as d3-scale did originally. But by upgrading this broke and we were receiving NaN values. These values made it so our graphs could not be displayed properly but only broke on graphs with undefined values.
hoorayimhelping
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: force coercion of falsy values to 0
guards against https://github.com/d3/d3-scale/releases/tag/v3.2.4
Issue: on april 28th 2021, we found an issue when we upgraded multiple giraffe libraries. This resulted in our graphs intermittently coming back empty/blank. This was because we had originally believed the null values would return 0, as d3-scale did originally. But by upgrading this broke and we were receiving NaN values. These values made it so our graphs could not be displayed properly but only broke on graphs with undefined values.