Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting Makefile To Allow Running Similar To Travis #661

Closed
wants to merge 3 commits into from
Closed

Adjusting Makefile To Allow Running Similar To Travis #661

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41d54a1
Adding Helpers To Allow Running Similar To Travis
Fenikkusu Mar 9, 2019
b5c5ba5
Updating git command - Previous only did since last commit.
Fenikkusu Mar 11, 2019
7b7159f
Removing Verbosity Flag (We do need the log)
Fenikkusu Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 16 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ BOX_URL="https://github.com/humbug/box/releases/download/3.1.0/box.phar"
PHP-CS-FIXER_URL="https://cs.sensiolabs.org/download/php-cs-fixer-v2.phar"
PHPSTAN_URL="https://github.com/phpstan/phpstan/releases/download/0.10.3/phpstan.phar"

TEST_TRAVIS_OPTIONS ?= false
ifeq ($(TEST_TRAVIS_OPTIONS),false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to do some if not eq to false, instead of an empty branch and then an else statement?
or even ifeq ($(TEST_TRAVIS_OPTIONS),true) ?

else
FILTER_OPTIONS := --filter=$(shell git diff master --name-only | grep \.php | tr '\n' ',')
INFECTION_TRAVIS_OPTIONS := --ignore-msi-with-no-mutations --only-covered --min-msi=90 --threads=4 --min-covered-msi=75 $(FILTER_OPTIONS)
endif

INFECTION_EXTRA_OPTIONS ?= --threads=4
INFECTION_OPTIONS ?= $(INFECTION_EXTRA_OPTIONS) $(INFECTION_TRAVIS_OPTIONS)

FLOCK=./devTools/flock

DOCKER_RUN=docker run -t --rm -v "$$PWD":/opt/infection -w /opt/infection
Expand Down Expand Up @@ -58,13 +68,13 @@ test-unit-73: build-xdebug-73
test-infection-phpdbg: test-infection-phpdbg-71 test-infection-phpdbg-72 test-infection-phpdbg-73

test-infection-phpdbg-71: build-xdebug-71
$(DOCKER_RUN_71) phpdbg -qrr bin/infection --threads=4
$(DOCKER_RUN_71) phpdbg $(PHP_OPTIONS) -qrr bin/infection $(INFECTION_OPTIONS)

test-infection-phpdbg-72: build-xdebug-72
$(DOCKER_RUN_72) phpdbg -qrr bin/infection --threads=4
$(DOCKER_RUN_72) phpdbg $(PHP_OPTIONS) -qrr bin/infection $(INFECTION_OPTIONS)

test-infection-phpdbg-73: build-xdebug-73
$(DOCKER_RUN_73) phpdbg -qrr bin/infection --threads=4
$(DOCKER_RUN_73) phpdbg $(PHP_OPTIONS) -qrr bin/infection $(INFECTION_OPTIONS)


.PHONY: test-e2e-phpdbg test-e2e-phpdbg-71 test-e2e-phpdbg-72 test-e2e-phpdbg-73
Expand All @@ -86,13 +96,13 @@ test-e2e-phpdbg-73: build-xdebug-73 $(INFECTION)
test-infection-xdebug: test-infection-xdebug-71 test-infection-xdebug-72 test-infection-xdebug-73

test-infection-xdebug-71: build-xdebug-71
$(DOCKER_RUN_71) php bin/infection --threads=4
$(DOCKER_RUN_71) php $(PHP_OPTIONS) bin/infection $(INFECTION_OPTIONS)

test-infection-xdebug-72: build-xdebug-72
$(DOCKER_RUN_72) php bin/infection --threads=4
$(DOCKER_RUN_72) php $(PHP_OPTIONS) bin/infection $(INFECTION_OPTIONS)

test-infection-xdebug-73: build-xdebug-73
$(DOCKER_RUN_73) php bin/infection --threads=4
$(DOCKER_RUN_73) php $(PHP_OPTIONS) bin/infection $(INFECTION_OPTIONS)

.PHONY: test-e2e-xdebug test-e2e-xdebug-71 test-e2e-xdebug-72 test-e2e-xdebug-73
#e2e tests with xdebug
Expand Down