Adjusting Makefile To Allow Running Similar To Travis #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenikkusu
changed the title
|
Tests Failing Due To #631 |
BackEndTea
reviewed
Apr 25, 2019
| @@ -9,6 +9,16 @@ BOX_URL="https://github.com/humbug/box/releases/download/3.1.0/box.phar" | |||
| PHP-CS-FIXER_URL="https://cs.sensiolabs.org/download/php-cs-fixer-v2.phar" | |||
| PHPSTAN_URL="https://github.com/phpstan/phpstan/releases/download/0.10.3/phpstan.phar" | |||
|
|
|||
| TEST_TRAVIS_OPTIONS ?= false | |||
| ifeq ($(TEST_TRAVIS_OPTIONS),false) | |||
There was a problem hiding this comment.
Wouldn't it be better to do some if not eq to false, instead of an empty branch and then an else statement?
or even ifeq ($(TEST_TRAVIS_OPTIONS),true) ?
|
Is this still relevant with the recent changes we did regarding the CI configuration and Makefile improvements? |
|
Honestly, I haven't been able to get back to this in quite a while so I'm not sure. I'll just close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
While working on another MR, I was getting errors in travis and couldn't figure out the issues. Once I realized it was because of extra parameters used to run in travis, I wanted to replicate them locally so I wouldn't have to fix/push/fix/push etc, as well as get an output of the issues.
This PR adds additional options to the Makefile to allow simple access to travis mode. By running
TEST_TRAVIS_OPTIONS=true make test(Or another other run command), make will automatically append additional options that are pretty much the same as travis would run. I also added in the PHP_OPTIONS flag to pass options to php when running. For example, I kept getting a few memory limit issues, so I can now runPHP_OPTIONS="-d memory_limit=-1" make test(Yes, I know about the infection config option as well, but this came in hand for other items too).