Enhancement: Implement UnwrapArrayReverse mutator #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/array-reverse-unwrap
branch
2 times, most recently
from
f52601b
to
045bfa8
Compare
localheinz
commented
Oct 29, 2018
| Mutator\Unwrap\UnwrapArrayFilter::class, | ||
| Mutator\Unwrap\UnwrapArrayMap::class, |
There was a problem hiding this comment.
| 'UnwrapArrayFilter' => Mutator\Unwrap\UnwrapArrayFilter::class, | ||
| 'UnwrapArrayMap' => Mutator\Unwrap\UnwrapArrayMap::class, |
There was a problem hiding this comment.
1 task
localheinz
commented
Oct 29, 2018
| $this->doTest($input, $expected); | ||
| } | ||
|
|
||
| public function provideMutationCases(): \Generator |
There was a problem hiding this comment.
Should I add any cases that involve the $preserve_keys parameter?
There was a problem hiding this comment.
For the sake of completeness, sure why not.
There was a problem hiding this comment.
Not sure about the number of tests, do we need to have three instead of one data set
- as is at the moment
- with
$preserve_keysset tofalse - with
$preserve_keysset totrue
or will two more test cases suffice?
There was a problem hiding this comment.
I'd leave it with just one test with an extra argument. It can be a variable like so:
- $a = array_reverse(['foo'], $preserve_keys);
+ $a = ['foo'];
sanmai
previously approved these changes
Oct 30, 2018
akondas
reviewed
Oct 30, 2018
| <<<'PHP' | ||
| <?php | ||
|
|
||
| function array_reduce($array) |
There was a problem hiding this comment.
Ha, thank you, @akondas!
localheinz
force-pushed
the
feature/array-reverse-unwrap
branch
4 times, most recently
from
6234bcf
to
7518132
Compare
localheinz
force-pushed
the
feature/array-reverse-unwrap
branch
from
7518132
to
629afcc
Compare
localheinz
changed the title
46 tasks
raphaelstolt
pushed a commit
to raphaelstolt/infection
that referenced
this pull request
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
UnwrapArrayReversemutatorRelated to #514.
💁♂️ Follows the example in #513.