Skip to content

Commit

Permalink
Enhancement: Implement ArrayReverseUnwrap mutator
Browse files Browse the repository at this point in the history
  • Loading branch information
localheinz committed Oct 30, 2018
1 parent 6b80024 commit 6234bcf
Show file tree
Hide file tree
Showing 3 changed files with 195 additions and 2 deletions.
26 changes: 26 additions & 0 deletions src/Mutator/Unwrap/UnwrapArrayReverse.php
@@ -0,0 +1,26 @@
<?php
/**
* Copyright © 2017-2018 Maks Rafalko
*
* License: https://opensource.org/licenses/BSD-3-Clause New BSD License
*/

declare(strict_types=1);

namespace Infection\Mutator\Unwrap;

/**
* @internal
*/
final class UnwrapArrayReverse extends AbstractUnwrapMutator
{
protected function getFunctionName(): string
{
return 'array_reverse';
}

protected function getParameterIndex(): int
{
return 0;
}
}
6 changes: 4 additions & 2 deletions src/Mutator/Util/MutatorProfile.php
Expand Up @@ -161,8 +161,9 @@ final class MutatorProfile
];

public const UNWRAP = [
Mutator\Unwrap\UnwrapArrayMap::class,
Mutator\Unwrap\UnwrapArrayFilter::class,
Mutator\Unwrap\UnwrapArrayMap::class,
Mutator\Unwrap\UnwrapArrayReverse::class,
];

public const DEFAULT = [
Expand Down Expand Up @@ -286,7 +287,8 @@ final class MutatorProfile
'CastString' => Mutator\Cast\CastString::class,

// Unwrap
'UnwrapArrayMap' => Mutator\Unwrap\UnwrapArrayMap::class,
'UnwrapArrayFilter' => Mutator\Unwrap\UnwrapArrayFilter::class,
'UnwrapArrayMap' => Mutator\Unwrap\UnwrapArrayMap::class,
'UnwrapArrayReverse' => Mutator\Unwrap\UnwrapArrayReverse::class,
];
}
165 changes: 165 additions & 0 deletions tests/Mutator/Unwrap/UnwrapArrayReverseTest.php
@@ -0,0 +1,165 @@
<?php
/**
* Copyright © 2017-2018 Maks Rafalko
*
* License: https://opensource.org/licenses/BSD-3-Clause New BSD License
*/

declare(strict_types=1);

namespace Infection\Tests\Mutator\Unwrap;

use Infection\Tests\Mutator\AbstractMutatorTestCase;

/**
* @internal
*/
final class UnwrapArrayReverseTest extends AbstractMutatorTestCase
{
/**
* @dataProvider provideMutationCases
*/
public function test_mutator($input, $expected = null): void
{
$this->doTest($input, $expected);
}

public function provideMutationCases(): \Generator
{
yield 'It mutates correctly when provided with an array' => [
<<<'PHP'
<?php
$a = array_reverse(['A', 1, 'C']);
PHP
,
<<<'PHP'
<?php
$a = ['A', 1, 'C'];
PHP
];

yield 'It mutates correctly when provided with a constant' => [
<<<'PHP'
<?php
$a = array_reverse(\Class_With_Const::Const);
PHP
,
<<<'PHP'
<?php
$a = \Class_With_Const::Const;
PHP
];

yield 'It mutates correctly when a backslash is in front of array_reverse' => [
<<<'PHP'
<?php
$a = \array_reverse(['A', 1, 'C']);
PHP
,
<<<'PHP'
<?php
$a = ['A', 1, 'C'];
PHP
];

yield 'It does not mutate other array_ calls' => [
<<<'PHP'
<?php
$a = array_map('strtolower', ['A', 'B', 'C']);
PHP
];

yield 'It does not mutate functions named array_reverse' => [
<<<'PHP'
<?php
function array_reverse($array)
{
}
PHP
];

yield 'It mutates correctly within if statements' => [
<<<'PHP'
<?php
$a = ['A', 1, 'C'];
if (array_reverse($a) === $a) {
return true;
}
PHP
,
<<<'PHP'
<?php
$a = ['A', 1, 'C'];
if ($a === $a) {
return true;
}
PHP
];

yield 'It mutates correctly when array_reverse is wrongly capitalized' => [
<<<'PHP'
<?php
$a = aRrAy_ReVeRsE(['A', 1, 'C']);
PHP
,
<<<'PHP'
<?php
$a = ['A', 1, 'C'];
PHP
];

yield 'It mutates correctly when array_reverse uses another function as input' => [
<<<'PHP'
<?php
$a = array_reverse($foo->bar());
PHP
,
<<<'PHP'
<?php
$a = $foo->bar();
PHP
];

yield 'It mutates correctly when provided with a more complex situation' => [
<<<'PHP'
<?php
$a = array_map('strtolower', array_reverse(['A', 1, 'C']));
PHP
,
<<<'PHP'
<?php
$a = array_map('strtolower', ['A', 1, 'C']);
PHP
];

yield 'It mutates correctly when the $preserve_keys parameter is present' => [
<<<'PHP'
<?php
$a = array_reverse(['A', 1, 'C'], $b);
PHP
,
<<<'PHP'
<?php
$a = ['A', 1, 'C'];
PHP
];
}
}

0 comments on commit 6234bcf

Please sign in to comment.