Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not increment max integer value (fixes #1484) #1486

Merged
merged 1 commit into from Feb 22, 2021
Merged

fix: Do not increment max integer value (fixes #1484) #1486

merged 1 commit into from Feb 22, 2021

Conversation

DeepDiver1975
Copy link
Contributor

@DeepDiver1975 DeepDiver1975 commented Feb 22, 2021 •
edited by maks-rafalko

This PR:

  • Covered by tests

Fixes #1484

maks-rafalko
maks-rafalko approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Could you please run make cs to fix style issues?

@maks-rafalko maks-rafalko added this to the 0.22.0 milestone Feb 22, 2021
@DeepDiver1975
Copy link
Contributor Author

Could you please run make cs to fix style issues?

I tried .... see #1487 ;-)

@sanmai sanmai merged commit afe9b39 into infection:master Feb 22, 2021
@DeepDiver1975 DeepDiver1975 deleted the fix/max-int-value-increment branch February 22, 2021 13:01
@maks-rafalko
Copy link
Member

Thank you @DeepDiver1975

maks-rafalko pushed a commit that referenced this pull request Feb 22, 2021
@DeepDiver1975 @maks-rafalko
Do not increment max integer value (fixes #1484) (#1486)
3248417
@MidnightDesign
Copy link
Sponsor Contributor

The test won't work on a 32-bit system, will it?

@maks-rafalko maks-rafalko mentioned this pull request Feb 23, 2021
Merged
@maks-rafalko
Copy link
Member

The test won't work on a 32-bit system, will it?

Looks like yes, see #1490

@renovate renovate bot mentioned this pull request May 22, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
0.22.0
4 participants
@DeepDiver1975 @maks-rafalko @MidnightDesign @sanmai