Do not increment max integer value (fixes #1484) (#1486)

infection · Feb 22, 2021 · 3248417 · 3248417
1 parent dfacb1e
commit 3248417
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Mutator/Number/IncrementInteger.php b/src/Mutator/Number/IncrementInteger.php
@@ -39,6 +39,7 @@
 use Infection\Mutator\GetMutatorName;
 use Infection\Mutator\MutatorCategory;
 use Infection\PhpParser\Visitor\ParentConnector;
+use const PHP_INT_MAX;
 use PhpParser\Node;
 
 /**
@@ -87,6 +88,10 @@ public function canMutate(Node $node): bool
             return false;
         }
 
+        if ($node->value === PHP_INT_MAX) {
+            return false;
+        }
+
         if (
             $node->value === 0
             && ($this->isPartOfComparison($node) || ParentConnector::getParent($node) instanceof Node\Expr\Assign)

diff --git a/tests/phpunit/Mutator/Number/IncrementIntegerTest.php b/tests/phpunit/Mutator/Number/IncrementIntegerTest.php
@@ -239,6 +239,20 @@ public function mutationsProvider(): iterable
 <?php
 
 preg_split('//', 'string', -1);
+PHP
+        ];
+
+        yield 'It does not increment max int' => [
+            <<<'PHP'
+<?php
+
+random_int(10000000, 9223372036854775807);
+PHP
+            ,
+            <<<'PHP'
+<?php
+
+random_int(10000001, 9223372036854775807);
 PHP
         ];
     }