Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Mutator::mutate() is mutations-free #1382

Merged
merged 5 commits into from
Oct 28, 2020
Merged

Ensure Mutator::mutate() is mutations-free #1382

merged 5 commits into from
Oct 28, 2020

Conversation

sanmai
Copy link
Member

@sanmai sanmai commented Oct 28, 2020 •
edited

This PR:

@sanmai sanmai changed the title Add example of not working YieldValue mutator Ensure Mutator::mutate() is mutations-free Oct 28, 2020
@sanmai sanmai marked this pull request as ready for review October 28, 2020 02:49
@sanmai sanmai added the Bugfix label Oct 28, 2020
maks-rafalko
maks-rafalko approved these changes Oct 28, 2020
View reviewed changes
tests/e2e/YieldValue/README.md Outdated Show resolved Hide resolved
@maks-rafalko maks-rafalko merged commit 7d42b2b into master Oct 28, 2020
@maks-rafalko maks-rafalko deleted the bug/yield-value branch October 28, 2020 09:19
@maks-rafalko
Copy link
Member

Thank you @sanmai

maks-rafalko added a commit that referenced this pull request Oct 28, 2020
@sanmai @maks-rafalko
Ensure Mutator::mutate() is mutations-free (#1382)
46c17a7 
* Update UnwrapArrayChunk, UnwrapArrayColumn

* Ensure Mutator::mutate() is mutations-free

* Add example of not working YieldValue mutator

* Use a more transparent log format

* Update tests/e2e/YieldValue/README.md

Co-authored-by: mak-srafalko <b0rn@list.ru>
@sanmai sanmai mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maks-rafalko maks-rafalko maks-rafalko approved these changes

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YieldValue mutator does not generate any mutations
2 participants
@sanmai @maks-rafalko