Update static analyze tools #1532

sidz · 2021-07-06T20:43:41Z

This PR update psalm and phpstan and fixing some founded violations

sidz · 2021-07-06T20:44:21Z

psalm.xml

    resolveFromConfigFile="true"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns="https://getpsalm.org/schema/config"
    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
-    errorBaseline="psalm-baseline.xml"


all issues has been fixed

sidz · 2021-07-06T20:45:03Z

psalm.xml

@@ -1,17 +1,16 @@
 <?xml version="1.0"?>
 <psalm
-    errorLevel="8"
+    errorLevel="7"


wondered why we use the lowest possible error level in psalm. So bump it up to 7 and fixed couple new violations

sidz · 2021-07-06T20:45:23Z

psalm.xml

 >
    <projectFiles>
-        <directory name="src/Mutator" />


didn't realize why we scan src/Mutator directory only

We didn't use Psalm for anything else but to guard against @psalm-mutation-free

sidz · 2021-07-06T20:46:19Z

src/Mutator/Arithmetic/Assignment.php

@@ -68,8 +68,6 @@ public static function getDefinition(): ?Definition
    }

    /**
-     * @psalm-mutation-free


all @psalm-mutation-fee generates

ERROR: ImpureMethodCall - src/Mutator/Arithmetic/MinusEqual.php:76:75 - Cannot call an possibly-mutating method PhpParser\Node::getAttributes from a mutation-free context (see https://psalm.dev/203) yield new Node\Expr\AssignOp\Plus($node->var, $node->expr, $node->getAttributes());

Let's recall we've added these in #1382 on purpose because we have very annoying and hard to debug bugs.

sidz · 2021-07-06T20:47:40Z

src/TestFramework/AbstractTestFrameworkAdapter.php

     *
     * @return string[]
     */
    public function getMutantCommandLine(
-        array $tests,
-        string $mutantFilePath,
+        array $coverageTests,


psalm on level 7 generates an error:

ERROR: ParamNameMismatch - src/TestFramework/AbstractTestFrameworkAdapter.php:105:15 - Argument 1 of Infection\TestFramework\AbstractTestFrameworkAdapter::getMutantCommandLine has wrong name $tests, expecting $coverageTests as defined by Infection\AbstractTestFramework\TestFrameworkAdapter::getMutantCommandLine (see https://psalm.dev/230) array $tests,

that is why property has been renamed. (the next renamed for the same reason)

sidz · 2021-07-06T20:57:42Z

composer.json

@@ -67,8 +67,7 @@
        "webmozart/path-util": "^2.3"
    },
    "conflict": {
-        "phpunit/php-code-coverage": ">9 <9.1.4",
-        "symfony/console": "=4.1.5"


no longer required as we supports symfony/console:^4.1.19

sanmai

@psalm-mutation-fee are there for a reason

sanmai · 2021-07-07T06:34:13Z

src/Mutator/Arithmetic/Assignment.php

@@ -68,8 +68,6 @@ public static function getDefinition(): ?Definition
    }

    /**
-     * @psalm-mutation-free


Let's recall we've added these in #1382 on purpose because we have very annoying and hard to debug bugs.

sidz · 2021-07-07T20:27:06Z

@sanmai unfortunately #1382 doesn't have any explanation about which kind of annoying bugs we solved by using it.

p.s. I've put @psalm-mutation-free back.

maks-rafalko · 2021-07-07T20:52:49Z

@sidz this comment explains the reasons #1380 (comment), this change shows the bug: https://github.com/infection/infection/pull/1382/files#diff-d275481b2f5803179e7bc177f10fd78be286885b52cb0b9922ebe51c125f5137L81

we can add explanation (and probably a link?) to the Mutator interface near @psalm-mutation-free to explain why it's needed, here

infection/src/Mutator/Mutator.php

Line 53 in 8c97e07

* @psalm-mutation-free

sidz · 2021-07-12T06:33:20Z

@maks-rafalko added

kubawerlos · 2021-09-20T20:23:56Z

.php-cs-fixer.dist.php

@@ -63,7 +63,6 @@
    ])
    ->ignoreDotFiles(false)
    ->name('*php')
-    ->name('.php_cs.dist')


This was for PHP CS Fixer 2, can you add ->append([__FILE__]), so the config is self checked.

sidz · 2021-11-16T21:20:44Z

It's time to back to this PR :)
So as a lot of stuff were done by @kubawerlos I updated psalm to the latest version on this moment, bumped up errorLevel to 6 and fix couple of founded issues.

so ready for re-review @maks-rafalko, @sanmai

sanmai

Tested this by reintroducing the issue fixed in 7d42b2b (that's when we started to use Psalm). It caught it all right.

sanmai · 2021-11-17T04:08:49Z

psalm.xml

+
+        <ImpureFunctionCall>
+            <errorLevel type="suppress">
+                <directory name="src/Mutator"/>


Suggested change

<directory name="src/Mutator"/>

<directory name="src/Mutator/Regex"/>

sanmai · 2021-11-17T04:09:16Z

psalm.xml

 >
    <projectFiles>
-        <directory name="src/Mutator" />


We didn't use Psalm for anything else but to guard against @psalm-mutation-free

sidz · 2021-11-17T09:19:18Z

thanks @maks-rafalko, @sanmai

sidz commented Jul 6, 2021

View reviewed changes

sidz force-pushed the update-static-analyze-tools branch 2 times, most recently from 7f9902b to 7e66fd1 Compare July 6, 2021 20:56

sidz commented Jul 6, 2021

View reviewed changes

maks-rafalko approved these changes Jul 6, 2021

View reviewed changes

sanmai requested changes Jul 7, 2021

View reviewed changes

sidz force-pushed the update-static-analyze-tools branch from 7e66fd1 to 80587f3 Compare July 7, 2021 06:36

sanmai self-requested a review July 12, 2021 08:11

sidz force-pushed the update-static-analyze-tools branch from aa33fef to 77d96f1 Compare July 16, 2021 07:44

kubawerlos suggested changes Sep 20, 2021

View reviewed changes

sidz force-pushed the update-static-analyze-tools branch from 77d96f1 to b93bc5c Compare November 16, 2021 21:17

sanmai approved these changes Nov 17, 2021

View reviewed changes

maks-rafalko approved these changes Nov 17, 2021

View reviewed changes

Update Psalm and bump errorLevel to 6

c7f975b

sidz force-pushed the update-static-analyze-tools branch from b93bc5c to c7f975b Compare November 17, 2021 08:18

sidz merged commit 735cd3b into master Nov 17, 2021

sidz deleted the update-static-analyze-tools branch November 17, 2021 09:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update static analyze tools #1532

Update static analyze tools #1532

sidz commented Jul 6, 2021

sidz Jul 6, 2021

sidz Jul 6, 2021

sidz Jul 6, 2021

sanmai Nov 17, 2021

sidz Jul 6, 2021

sanmai Jul 7, 2021

sidz Jul 6, 2021

sidz Jul 6, 2021

sanmai left a comment

sanmai Jul 7, 2021

sidz commented Jul 7, 2021 •

edited

maks-rafalko commented Jul 7, 2021

sidz commented Jul 12, 2021

kubawerlos Sep 20, 2021

sidz commented Nov 16, 2021

sanmai left a comment

sanmai Nov 17, 2021

sanmai Nov 17, 2021

sidz commented Nov 17, 2021

	<directory name="src/Mutator"/>
	<directory name="src/Mutator/Regex"/>

Update static analyze tools #1532

Update static analyze tools #1532

Conversation

sidz commented Jul 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanmai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sidz commented Jul 7, 2021 • edited

maks-rafalko commented Jul 7, 2021

sidz commented Jul 12, 2021

Choose a reason for hiding this comment

sidz commented Nov 16, 2021

sanmai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sidz commented Nov 17, 2021

sidz commented Jul 7, 2021 •

edited