TestLocator returns non-unique tests, but Mutation didn't know that

Fixes #1304

TestLocator returns non-unique tests, and JUnitTestCaseSorter works around that; we have to do that too.

src/Mutation/Mutation.php

@@ -37,14 +37,14 @@
 
 use function array_intersect_key;
 use function array_keys;
-use function array_map;
 use function array_sum;
 use function implode;
 use Infection\AbstractTestFramework\Coverage\TestLocation;
 use Infection\Mutator\ProfileList;
 use Infection\PhpParser\MutatedNode;
 use function md5;
 use PhpParser\Node;
+use function Pipeline\take;
 use function Safe\array_flip;
 use Webmozart\Assert\Assert;
 
@@ -165,11 +165,13 @@ public function getAllTests(): array
      */
     public function getNominalTestExecutionTime(): float
     {
-        return $this->nominalTimeToTest ?? $this->nominalTimeToTest = array_sum(array_map(
-            static function (TestLocation $testLocation) {
-                return $testLocation->getExecutionTime();
-            },
-            $this->tests
+        // TestLocator returns non-unique tests, and JUnitTestCaseSorter works around that; we have to do that too.
+        return $this->nominalTimeToTest ?? $this->nominalTimeToTest = array_sum(iterator_to_array(
+            take($this->tests)
+                ->map(static function (TestLocation $testLocation) {
+                    yield $testLocation->getMethod() => $testLocation->getExecutionTime();
+                }),
+            true
         ));
     }
 

tests/e2e/TimeoutSkipped/composer.json

@@ -0,0 +1,15 @@
+{
+    "require-dev": {
+        "phpunit/phpunit": "^8"
+    },
+    "autoload": {
+        "psr-4": {
+            "TimeoutSkipped\\": "src/"
+        }
+    },
+    "autoload-dev": {
+        "psr-4": {
+            "TimeoutSkipped\\Test\\": "tests/"
+        }
+    }
+}

tests/e2e/TimeoutSkipped/expected-output.txt

@@ -0,0 +1,8 @@
+Total: 5
+
+Killed: 2
+Errored: 0
+Escaped: 2
+Timed Out: 1
+Skipped: 0
+Not Covered: 0

tests/e2e/TimeoutSkipped/infection.json

@@ -0,0 +1,12 @@
+{
+    "timeout": 2,
+    "source": {
+        "directories": [
+            "src"
+        ]
+    },
+    "logs": {
+        "summary": "infection.log"
+    },
+    "tmpDir": "."
+}

tests/e2e/TimeoutSkipped/phpunit.xml.dist

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
+         bootstrap="./vendor/autoload.php"
+         colors="true"
+>
+    <testsuites>
+        <testsuite name="Test Suite">
+            <directory>./tests/</directory>
+        </testsuite>
+    </testsuites>
+
+    <filter>
+        <whitelist>
+            <directory>./src/</directory>
+        </whitelist>
+    </filter>
+</phpunit>

tests/e2e/TimeoutSkipped/src/SourceClass.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace TimeoutSkipped;
+
+class SourceClass
+{
+    public function add(int $a, int $b): int
+    {
+        sleep(1);
+        return $a + $b;
+    }
+}

tests/e2e/TimeoutSkipped/tests/SourceClassTest.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace TimeoutSkipped\Test;
+
+use TimeoutSkipped\SourceClass;
+use PHPUnit\Framework\TestCase;
+
+class SourceClassTest extends TestCase
+{
+    public function test_it_adds_2_numbers(): void
+    {
+        $source = new SourceClass();
+
+        $result = $source->add(1, 2);
+
+        self::assertSame(3, $result);
+    }
+}

tests/phpunit/Mutation/MutationTest.php

@@ -64,6 +64,7 @@ public function test_it_can_be_instantiated(
         MutatedNode $mutatedNode,
         int $mutationByMutatorIndex,
         array $tests,
+        float $timeToTest,
         array $expectedAttributes,
         int $expectedOriginalStartingLine,
         bool $expectedCoveredByTests,
@@ -88,6 +89,7 @@ public function test_it_can_be_instantiated(
         $this->assertSame($mutatedNodeClass, $mutation->getMutatedNodeClass());
         $this->assertSame($mutatedNode, $mutation->getMutatedNode());
         $this->assertSame($tests, $mutation->getAllTests());
+        $this->assertSame($timeToTest, $mutation->getNominalTestExecutionTime());
         $this->assertSame($expectedCoveredByTests, $mutation->isCoveredByTest());
         $this->assertSame($expectedHash, $mutation->getHash());
     }
@@ -112,6 +114,7 @@ public function valuesProvider(): iterable
             MutatedNode::wrap(new Node\Scalar\LNumber(1)),
             -1,
             [],
+            0.0,
             $nominalAttributes,
             $originalStartingLine,
             false,
@@ -136,6 +139,7 @@ public function valuesProvider(): iterable
                     0.01
                 ),
             ],
+            0.01,
             $nominalAttributes,
             $originalStartingLine,
             true,
@@ -160,6 +164,7 @@ public function valuesProvider(): iterable
                     0.01
                 ),
             ],
+            0.01,
             $nominalAttributes,
             $originalStartingLine,
             true,
@@ -181,9 +186,15 @@ public function valuesProvider(): iterable
                 new TestLocation(
                     'FooTest::test_it_can_instantiate',
                     '/path/to/acme/FooTest.php',
-                    0.01
+                    1.1
+                ),
+                new TestLocation(
+                    'FooTest::test_it_can_instantiate',
+                    '/path/to/acme/FooTest.php',
+                    1.1
                 ),
             ],
+            1.1,
             $nominalAttributes,
             $originalStartingLine,
             true,
@@ -202,6 +213,7 @@ public function valuesProvider(): iterable
             MutatedNode::wrap(new Node\Scalar\LNumber(1)),
             0,
             [],
+            0.0,
             $nominalAttributes,
             $originalStartingLine,
             false,
@@ -229,6 +241,7 @@ public function valuesProvider(): iterable
                     0.01
                 ),
             ],
+            0.01,
             $nominalAttributes,
             $originalStartingLine,
             true,