Infection must return appropriate exit status when failing (#1299)

* Infection must return appropriate exit status when failing * Update src/Command/BaseCommand.php
infection · Aug 19, 2020 · 31e4af4 · 31e4af4
1 parent 9488dfd
commit 31e4af4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/Command/BaseCommand.php b/src/Command/BaseCommand.php
@@ -75,12 +75,10 @@ protected function initialize(InputInterface $input, OutputInterface $output): v
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $this->executeCommand($this->getIO());
-
-        return 0;
+        return $this->executeCommand($this->getIO()) ? 0 : 1;
     }
 
-    abstract protected function executeCommand(IO $io): void;
+    abstract protected function executeCommand(IO $io): bool;
 
     final protected function getIO(): IO
     {

diff --git a/src/Command/ConfigureCommand.php b/src/Command/ConfigureCommand.php
@@ -84,7 +84,7 @@ protected function configure(): void
             );
     }
 
-    protected function executeCommand(IO $io): void
+    protected function executeCommand(IO $io): bool
     {
         if (!$io->isInteractive()) {
             $io->writeln(self::NONINTERACTIVE_MODE_ERROR);
@@ -156,6 +156,8 @@ protected function executeCommand(IO $io): void
             SchemaConfigurationLoader::DEFAULT_DIST_CONFIG_FILE
         ));
         $io->newLine();
+
+        return true;
     }
 
     /**

diff --git a/src/Command/RunCommand.php b/src/Command/RunCommand.php
@@ -213,7 +213,7 @@ protected function configure(): void
         ;
     }
 
-    protected function executeCommand(IO $io): void
+    protected function executeCommand(IO $io): bool
     {
         $logger = new ConsoleLogger($io);
         $container = $this->createContainer($io, $logger);
@@ -238,10 +238,14 @@ protected function executeCommand(IO $io): void
 
         try {
             $engine->execute();
+
+            return true;
         } catch (InitialTestsFailed | MinMsiCheckFailed $exception) {
             // TODO: we can move that in a dedicated logger later and handle those cases in the
             // Engine instead
             $io->error($exception->getMessage());
+
+            return false;
         }
     }