Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed v0.8.3 [don't merge PR] #629

Closed
wants to merge 1 commit into from
Closed

Proposed v0.8.3 [don't merge PR] #629

wants to merge 1 commit into from

Conversation

dbr
Copy link
Contributor

@dbr dbr commented Mar 19, 2022

(note: I've made this new branch, named patch-v0.8, which holds all the tags/patch commits from v0.8.x. Also this PR just exists for visiblity of the commits - would be a terrible idea to actually merge, thus the draft status)

Compared to the 0.8.2 release, this contains:

`parking_lot` now uses windows-rs's `windows-sys` crate, officially
developed and vetted by Microsoft - the bindings are autogenerated from
metadata and faster to compile too.

See also Amanieu/parking_lot#311.
@dbr dbr changed the base branch from main to v0.8.2-patch March 19, 2022 11:17
@dbr dbr changed the base branch from v0.8.2-patch to main March 19, 2022 11:17
@dbr
Copy link
Contributor Author

dbr commented Mar 19, 2022

Oh I breifly thought parking_lot might be in the public API so would arguably be a breaking change,

https://github.com/imgui-rs/imgui-rs/blob/patch-v0.8/imgui/src/test.rs#L6

..but that's only enabled under #[cfg(test)] and otherwise only used internally, so I think this is fine 🤔

https://github.com/imgui-rs/imgui-rs/blob/patch-v0.8/imgui/src/lib.rs#L84-L85

@MarijnS95
Copy link
Contributor

Even though this probably doesn't matter as it "is superseded" by #645, can you update the target branch to https://github.com/imgui-rs/imgui-rs/compare/v0.8.2-patch, which this branch is based on top of (it looks like this was the base branch for a split-second)? That makes the diff much more obvious to read/understand.

(Perhaps that branch should be renamed though, #645 (comment))

@dbr dbr changed the base branch from main to v0.8.2-patch July 21, 2022 04:06
@dbr
Copy link
Contributor Author

dbr commented Nov 22, 2022

Closing this in favour of releasing v0.9

@dbr dbr closed this Nov 22, 2022
@dbr dbr deleted the patch-v0.8 branch November 30, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants