Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc.rs build is failing #631

Closed
Jasper-Bekkers opened this issue Mar 19, 2022 · 7 comments
Closed

doc.rs build is failing #631

Jasper-Bekkers opened this issue Mar 19, 2022 · 7 comments
Assignees

Comments

@Jasper-Bekkers
Copy link
Collaborator

It looks like the build is failing because a C++ file is missing, probably not included in the Cargo.toml file to be uploaded or something?

https://docs.rs/crate/imgui/0.8.2/builds/482652

@dbr
Copy link
Contributor

dbr commented Mar 20, 2022

Yep the freetype.cpp was unintentionally excluded from the .crate, which caused builds to fail when a) using the crate and b) using freetype feature (whereas if you built from git it worked fine)

This should all be fixed in the patch-0.8 branch (#629 and specifically 155e758) - we just need to make a new 0.8.3 release to fix this - @sanbox-irl ?

@hammypants
Copy link

Currently the repo displays the latest main, wherein none of the examples match the API that you get from pulling 0.8.2, which that documentation you can't even see (in the accustomed format) because the doc.rs build is failing. So, to learn how to use the current available imgui-rs, you have to swap the github repo (or pull) to 0.8.2 and browse it by hand.

Rather confusing.

@thomcc
Copy link
Member

thomcc commented May 31, 2022

It looks like I still have publish privileges, so if @sanbox-irl is too busy I can cut a 0.8.3.

@sanbox-irl
Copy link
Member

Do it! I got a promotion at work and have been stuck on non tools tasks so I haven't had a chance to do much imgui work

@thomcc
Copy link
Member

thomcc commented May 31, 2022

Okay. I'll do it tomorrow, when I have a little more time. (Edit: Actually I'll do it now) I'll also try to update the bundled imgui (ours is 1.84.2, latest is 1.87), do we have documentation for the process there? (I believe the docs I wrote a while ago on it have fallen out of date)

@thomcc
Copy link
Member

thomcc commented May 31, 2022

It looks like updating imgui to 1.87 might be breaking change, so I'll hold off on that til after.

dbr added a commit to dbr/imgui-rs that referenced this issue Jun 2, 2022
Should verify the .crate file sent to crates.io can at least be built, which should catch things like the docs.rs build failure, as discussed in imgui-rs#645 and imgui-rs#631
@dbr
Copy link
Contributor

dbr commented Jan 6, 2023

Fixed a while ago with 0.9 release

@dbr dbr closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants