Request: Exit with code other than 0 if command-line args are malformed #409
Labels
Comments
alexdewar
added a commit
to ImperialCollegeLondon/poetry_template_2
that referenced
this issue
Jul 5, 2023
Unfortunately it seems that this hook has been broken since it was introduced. The problem is that when disabling rules you need an extra "--" at the end of the list. See: https://github.com/igorshubovych/markdownlint-cli Frustratingly, passing malformed arguments to markdownlint-cli means that the hook always passes (!). Upstream issue: igorshubovych/markdownlint-cli#409 I re-ran the hook on this repo, though, and there were no issues with the markdown.
|
Duplicate of #104 (and see related issues) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use
markdownlint-cliall over the place in our CI system via thepre-commithook (thanks for making it, btw!) and I've just noticed that the hook isn't actually running in a bunch of our repositories, because we're passing in dud command-line arguments, namely we've forgotten the terminating--after the list of rules to disable.markdownlintstill terminates with exit code 0 though, so thepre-commithook still passes. It would be better if it returned a non-zero exit code so that users don't accidentally break the hook like we did.The text was updated successfully, but these errors were encountered: