Skip to content

Commit

Permalink
Fix pre-commit hook for markdownlint
Browse files Browse the repository at this point in the history
Unfortunately it seems that this hook has been broken since it was
introduced. The problem is that when disabling rules you need an extra
"--" at the end of the list. See: https://github.com/igorshubovych/markdownlint-cli

Frustratingly, passing malformed arguments to markdownlint-cli means
that the hook always passes (!). Upstream issue: igorshubovych/markdownlint-cli#409

I re-ran the hook on this repo, though, and there were no issues with
the markdown.
  • Loading branch information
alexdewar committed Jul 5, 2023
1 parent b412e90 commit c73beb9
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,4 @@ repos:
rev: v0.35.0
hooks:
- id: markdownlint
args: ["--disable", "MD013"]

args: ["--disable", "MD013", "--"]

0 comments on commit c73beb9

Please sign in to comment.