Fix pre-commit hook for markdownlint #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately it seems that this hook has been broken since it was introduced. The problem is that when disabling rules you need an extra "--" at the end of the list. See: https://github.com/igorshubovych/markdownlint-cli Frustratingly, passing malformed arguments to markdownlint-cli means that the hook always passes (!). Upstream issue: igorshubovych/markdownlint-cli#409 I re-ran the hook on this repo, though, and there were no issues with the markdown.
alexdewar
requested review from
dalonsoa,
TinyMarsh,
cc-a,
AdrianDAlessandro,
dc2917 and
lkr-ind
This was referenced Jul 5, 2023
AdrianDAlessandro
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately it seems that this hook has been broken since it was introduced. The problem is that when disabling rules you need an extra "--" at the end of the list. See: https://github.com/igorshubovych/markdownlint-cli
Frustratingly, passing malformed arguments to markdownlint-cli means that the hook always passes (!). Upstream issue: igorshubovych/markdownlint-cli#409
I re-ran the hook on this repo, though, and there were no issues with the markdown.
Tagging everyone as a PSA 馃槃