bump xmldom to 0.6.0 to avoid bug where it keeps "<" in attributes (backport #1974) #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…1974) * bump xmldom to 0.6.0 to avoid bug where it keeps "<" in attributes see xmldom/xmldom#198 * add test which fails on version of 0.5.0 because of bad serialization * add valid entity serialization test * move serialization test down to serializer package instead of up at transformer level * better test name not referencing round trip Co-authored-by: Michael Belousov <MichaelBelousov@users.noreply.github.com> (cherry picked from commit 97a229f) # Conflicts: # common/config/rush/pnpm-lock.yaml
mergify
bot
requested review from
calebmshafer,
ColinKerr,
ramanujam-raman-zz,
wgoehrig and
a team
as code owners
MichaelBelousov
approved these changes
Aug 4, 2021
calebmshafer
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1974 done by Mergify.
Cherry-pick of 97a229f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/