bump xmldom to 0.6.0 to avoid bug where it keeps "<" in attributes #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBelousov
requested review from
calebmshafer,
ColinKerr,
ramanujam-raman-zz,
wgoehrig and
a team
as code owners
|
adding a test where a schema with |
|
@calebmshafer should this be backported? |
pmconne
approved these changes
Jul 30, 2021
calebmshafer
approved these changes
Aug 2, 2021
|
@calebmshafer I'm getting flaky integration and standalone backend tests, could you take a look? |
|
@skirby1996 is working on the extract-api issue. There's some combination of node version and something else causing a bunch of people issues. The The flaky integration tests, I have not looked into those yet so not quite sure. |
|
@calebmshafer when we get past that stuff, can we also backport this fix to 2.19? |
|
@Mergifyio update |
|
Command
|
|
@Mergifyio backport release/2.19.x |
mergify bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
…1974) * bump xmldom to 0.6.0 to avoid bug where it keeps "<" in attributes see xmldom/xmldom#198 * add test which fails on version of 0.5.0 because of bad serialization * add valid entity serialization test * move serialization test down to serializer package instead of up at transformer level * better test name not referencing round trip Co-authored-by: Michael Belousov <MichaelBelousov@users.noreply.github.com> (cherry picked from commit 97a229f) # Conflicts: # common/config/rush/pnpm-lock.yaml
|
Command
|
skirby1996
pushed a commit
that referenced
this pull request
Aug 4, 2021
…ackport #1974) (#1994) * bump xmldom to 0.6.0 to avoid bug where it keeps "<" in attributes (#1974) * bump xmldom to 0.6.0 to avoid bug where it keeps "<" in attributes see xmldom/xmldom#198 * add test which fails on version of 0.5.0 because of bad serialization * add valid entity serialization test * move serialization test down to serializer package instead of up at transformer level * better test name not referencing round trip Co-authored-by: Michael Belousov <MichaelBelousov@users.noreply.github.com> (cherry picked from commit 97a229f) # Conflicts: # common/config/rush/pnpm-lock.yaml * pushed merged pnpm-lock Co-authored-by: Michael Belousov <mike.belousov@bentley.com> Co-authored-by: Michael Belousov <MichaelBelousov@users.noreply.github.com>
khanaffan
pushed a commit
that referenced
this pull request
Aug 10, 2021
…1974) * bump xmldom to 0.6.0 to avoid bug where it keeps "<" in attributes see xmldom/xmldom#198 * add test which fails on version of 0.5.0 because of bad serialization * add valid entity serialization test * move serialization test down to serializer package instead of up at transformer level * better test name not referencing round trip Co-authored-by: Michael Belousov <MichaelBelousov@users.noreply.github.com>
khanaffan
pushed a commit
that referenced
this pull request
Aug 10, 2021
…1974) * bump xmldom to 0.6.0 to avoid bug where it keeps "<" in attributes see xmldom/xmldom#198 * add test which fails on version of 0.5.0 because of bad serialization * add valid entity serialization test * move serialization test down to serializer package instead of up at transformer level * better test name not referencing round trip Co-authored-by: Michael Belousov <MichaelBelousov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see xmldom/xmldom#199 and xmldom/xmldom#198
Some known schemas use
<and>in display labels, so this was breaking the imodel transformer which usedxmldom@0.5.0to serialize schemas during export to be imported into the target iModel.