Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @pytest.mark.fuzz and @pytest.mark.functional #5620

Merged
merged 3 commits into from
May 13, 2019
Merged

Remove @pytest.mark.fuzz and @pytest.mark.functional #5620

merged 3 commits into from
May 13, 2019

Commits on May 13, 2019

  1. Remove @pytest.mark.fuzz 

    This was an unregistered pytest mark, and pytest now emits a warning,
which causes our tests to fail, when an unregistered mark is used:

pytest-dev/pytest#4935

Rather than registering the mark simply delete all uses of it. All tests
that're defined using hypothesis automatically have the
`@pytest.mark.hypothesis` mark applied to them so it's not necessary to
try to remember to manually apply a custom mark to every test that uses
hypothesis:

https://hypothesis.readthedocs.io/en/latest/details.html#the-hypothesis-pytest-plugin
    @seanh
    seanh committed May 13, 2019
    Configuration menu
    Copy the full SHA
    80d280d View commit details
    Browse the repository at this point in the history

  2. Remove @pytest.mark.functional 

    This is an unregistered custom pytest mark, which causes pytest to omit
a warning and fail the tests. There doesn't seem to be any reason to
try to manually apply this mark to every single functional test -- these
tests are in a separate directory anyway. So rather than registering the
mark, delete it.
    @seanh
    seanh committed May 13, 2019
    Configuration menu
    Copy the full SHA
    4bbce1e View commit details
    Browse the repository at this point in the history

  3. Lint

    @seanh
    seanh committed May 13, 2019
    Configuration menu
    Copy the full SHA
    90b4382 View commit details
    Browse the repository at this point in the history