Remove @pytest.mark.fuzz and @pytest.mark.functional #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an unregistered pytest mark, and pytest now emits a warning, which causes our tests to fail, when an unregistered mark is used: pytest-dev/pytest#4935 Rather than registering the mark simply delete all uses of it. All tests that're defined using hypothesis automatically have the `@pytest.mark.hypothesis` mark applied to them so it's not necessary to try to remember to manually apply a custom mark to every test that uses hypothesis: https://hypothesis.readthedocs.io/en/latest/details.html#the-hypothesis-pytest-plugin
This is an unregistered custom pytest mark, which causes pytest to omit a warning and fail the tests. There doesn't seem to be any reason to try to manually apply this mark to every single functional test -- these tests are in a separate directory anyway. So rather than registering the mark, delete it.
seanh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were unregistered custom pytest marks, and pytest now emits a warning,
which causes our tests to fail, when an unregistered mark is used:
pytest-dev/pytest#4935
Rather than registering the mark simply delete all uses of it. All tests
that're defined using hypothesis automatically have the
@pytest.mark.hypothesismark applied to them so it's not necessary totry to remember to manually apply a custom mark to every test that uses
hypothesis:
https://hypothesis.readthedocs.io/en/latest/details.html#the-hypothesis-pytest-plugin
And our functional tests are in a separate directory, so trying to manually apply a mark to every one of those also seems unnecessary.