Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cdylib opt-in on latest nightly #2770

Merged
merged 3 commits into from Mar 3, 2022
Merged

Make cdylib opt-in on latest nightly #2770

merged 3 commits into from Mar 3, 2022

Commits on Mar 1, 2022

  1. fix(ffi): don't build C libraries by default 

    Remove unconditional building of FFI libraries: now
that nightly supports --crate-type, it can be opted into.
This fixes cargo's pipelining both for dependencies and
for dependent crates, resulting in faster from-scratch builds.
    @lqd
    lqd committed Mar 1, 2022
    Copy the full SHA
    2919bd3 View commit details
    Browse the repository at this point in the history

  2. chore(ci): test FFI on CI using nightly 

    Now that FFI is opt-in using cargo's --crate-type, nightly needs to be used
on CI: this flag is still unstable and requires a nightly to enable -Z unstable options.
    @lqd
    lqd committed Mar 1, 2022
    Copy the full SHA
    e6d6e5c View commit details
    Browse the repository at this point in the history

  3. docs(ffi): document nightly requirement for FFI 

    Update the command to use `--crate-type`.
    @lqd
    lqd committed Mar 1, 2022
    Copy the full SHA
    5b6f5a8 View commit details
    Browse the repository at this point in the history