Make cdylib opt-in on latest nightly #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unconditional building of FFI libraries: now that nightly supports --crate-type, it can be opted into. This fixes cargo's pipelining both for dependencies and for dependent crates, resulting in faster from-scratch builds.
Now that FFI is opt-in using cargo's --crate-type, nightly needs to be used on CI: this flag is still unstable and requires a nightly to enable -Z unstable options.
Update the command to use `--crate-type`.
|
cc #2685 |
seanmonstar
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest nightly includes rust-lang/cargo#10388, the fix for rust-lang/cargo#10356. This allows the cdylib to be built on the CLI rather than hyper having to set the crate-type in
Cargo.toml, and allows it to participate in cargo's pipelining to improve build times.This nightly is identified by rustup as
nightly-2022-03-02, and cargo's version iscargo 1.61.0-nightly (3d6970d 2022-02-28)I've tested rust's CI artifacts
6e5a6ffb14fc47051b0a23410c681ad6e4af045f(the PR updating cargo in rust), andnightly-2022-03-02, to build and test hyper with the new command:libhyper.sois built, and theclientexample successfully compiles.Here are links to timings of hyper master on nightly, and this PR with cargo 6e5a6ffb14fc47051b0a23410c681ad6e4af045f (release build at j8). The pipelining is now active (and surprisingly effective here, a 29% improvement)