Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HttpTryFrom<HashMap<String,String>> for HeaderMap #326
Implement HttpTryFrom<HashMap<String,String>> for HeaderMap #326
Changes from 3 commits
d591131
b76d702
660c4be
f2f91c7
1fbb55b
baabb0a
c951ff9
7c4dafe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should probably be an identity impl,
impl<T> HttpTryFrom<HeaderMap<T>> for HeaderMap<T>
. Would that conflict with the generic one below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
HeaderMap<T>
is itselfIntoIterator<Item=(HttpTryFrom<HeaderName>, HttpTryFrom<HeaderValue>)>
, soHeaderMap::try_from(header_map)
works as expected.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually one would expect
TryFrom<Me> for Me
to be basically free, but because that conflicts, it would be surprising that it essentially clones a newHeaderMap
....There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed sub-optimal, and can fixed later when rust adds support for specialization.
But until then, I think the usability benefits far outweigh this downside. The standard library itself has the same issue in several places, where an implementation is slower than it could be in order to be more generic.