Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HttpTryFrom<HashMap<String,String>> for HeaderMap #326

Merged
merged 8 commits into from Jul 25, 2019
Merged

Implement HttpTryFrom<HashMap<String,String>> for HeaderMap #326

merged 8 commits into from Jul 25, 2019

Commits on Jul 2, 2019

  1. Implement HttpTryFrom<HashMap<String,String>> for HeaderMap 

    This allows an easy conversion from HashMap<String,String>
to HeaderMap<HeaderValue>.

Doing this conversion used to be unnecessarily verbose
because of the required mapping and error type conversions.

The implementation is generic:

    impl<COLLECTION, K, V> HttpTryFrom<COLLECTION> for HeaderMap<HeaderValue>
    where
        COLLECTION: IntoIterator<Item=(K, V)>,
        K: AsRef<str>,
        V: AsRef<str>

so it also works for HashMap<HeaderName, String> and for vectors.

Fixes hyperium#325
    @lovasoa
    lovasoa committed Jul 2, 2019
    Copy the full SHA
    d591131 View commit details
    Browse the repository at this point in the history

  2. Avoid using crate:: paths for compatibility with older rust versions

    @lovasoa
    lovasoa committed Jul 2, 2019
    Copy the full SHA
    b76d702 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Implement conversion from HashMaps of any type, not just str 

    See: hyperium#326 (comment)
    @lovasoa
    lovasoa committed Jul 3, 2019
    Copy the full SHA
    660c4be View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Implement changes suggested by @seanmonstar 

    https://github.com/hyperium/http/pull/326/files#r302696965
https://github.com/hyperium/http/pull/326/files#r302697620
    @lovasoa
    lovasoa committed Jul 11, 2019
    Copy the full SHA
    f2f91c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Implement changes suggested by @seanmonstar 

    https://github.com/hyperium/http/pull/326/files#r302696965
https://github.com/hyperium/http/pull/326/files#r302697620
    @lovasoa
    lovasoa committed Jul 12, 2019
    Copy the full SHA
    1fbb55b View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Remove implementation for non-HashMap types 

    See hyperium#326 (comment)
    @lovasoa
    lovasoa committed Jul 23, 2019
    Copy the full SHA
    baabb0a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Remove implementation for HashMap, leaving only @hashmap 

    See hyperium#326 (comment)
    @lovasoa
    lovasoa committed Jul 24, 2019
    Copy the full SHA
    c951ff9 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Fix compilation for rust 1.20

    @lovasoa
    lovasoa committed Jul 25, 2019
    Copy the full SHA
    7c4dafe View commit details
    Browse the repository at this point in the history