Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termcolor now disables colour if not tty, but FORCE_COLOR for colour tests #107

Merged
merged 2 commits into from Nov 1, 2022

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Nov 1, 2022

Since https://github.com/termcolor/termcolor/releases/tag/2.1.0 and termcolor/termcolor#25, we need to make sure colour is enabled for these tests.

Fixes failures seen in #103, #104, #105, #106.

@hugovk hugovk added the changelog: Fixed For any bug fixes label Nov 1, 2022
@hugovk hugovk enabled auto-merge November 1, 2022 07:56
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #107 (90f9d95) into main (45159d6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   95.28%   95.30%   +0.01%     
==========================================
  Files           9        9              
  Lines         382      383       +1     
==========================================
+ Hits          364      365       +1     
  Misses         18       18              
Flag Coverage Δ
macos-latest 94.77% <100.00%> (-0.51%) ⬇️
ubuntu-latest 95.30% <100.00%> (+0.01%) ⬆️
windows-latest 95.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_norwegianblue.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hugovk hugovk added testing Unit tests, linting, CI, etc. changelog: skip Exclude PR from release draft and removed changelog: Fixed For any bug fixes labels Nov 1, 2022
@hugovk hugovk merged commit 8a56e1c into main Nov 1, 2022
@hugovk hugovk deleted the fix-termcolor branch November 1, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant