Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock instead of setting real env var #109

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Mock instead of setting real env var #109

merged 1 commit into from
Nov 1, 2022

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Nov 1, 2022

Follow up to #107, mock the env var instead of setting it directly, so as not to affect other tests.

@hugovk hugovk added testing Unit tests, linting, CI, etc. changelog: skip Exclude PR from release draft labels Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #109 (548f9eb) into main (e576831) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   95.30%   95.33%   +0.03%     
==========================================
  Files           9        9              
  Lines         383      386       +3     
==========================================
+ Hits          365      368       +3     
  Misses         18       18              
Flag Coverage Δ
macos-latest 95.33% <100.00%> (+0.03%) ⬆️
ubuntu-latest 95.33% <100.00%> (+0.03%) ⬆️
windows-latest 95.33% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_norwegianblue.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hugovk hugovk enabled auto-merge November 1, 2022 09:22
@hugovk hugovk merged commit eb1735c into main Nov 1, 2022
@hugovk hugovk deleted the mock branch November 1, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: skip Exclude PR from release draft testing Unit tests, linting, CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant