Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore SIGTERM signal exceptions. #269

Merged
merged 3 commits into from Mar 22, 2018
Merged

Ignore SIGTERM signal exceptions. #269

merged 3 commits into from Mar 22, 2018

Conversation

minhajuddin
Copy link
Contributor

Fixes #267

joshuap
joshuap reviewed Mar 21, 2018
View reviewed changes
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but JRuby builds are failing for some reason.

@minhajuddin
Copy link
Contributor Author

minhajuddin commented Mar 22, 2018 •
edited

Seems to be a bug in jruby, never expected I'd run into a compiler bug :) jruby/jruby#3954 Finding a workaround.

@joshuap joshuap merged commit c21d5c1 into honeybadger-io:master Mar 22, 2018
@minhajuddin minhajuddin deleted the fix/ignore-signal-exceptions branch April 10, 2018 05:41
@iftheshoefritz iftheshoefritz mentioned this pull request Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuap joshuap joshuap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minhajuddin @joshuap