-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SignalExceptions still being raised in rake tasks #306
Comments
The way our Rake integration works by default is that we report all errors that Rake displays (it's not related at all to https://github.com/honeybadger-io/honeybadger-ruby/blob/master/lib/honeybadger/init/rake.rb#L15 I think that it could make sense to automatically configure Honeybadger to ignore https://docs.honeybadger.io/ruby/getting-started/ignoring-errors.html If you only want the extra config inside Rake tasks (not the rest of your application), you could probably conditionally add the config with
|
Opened #309 to do this |
Responded on #309. I'll close this issue after I update docs.honeybadger.io with info on configuring Rake tasks to ignore these exceptions. |
Added to the troubleshooting guide here: https://docs.honeybadger.io/ruby/support/troubleshooting.html#signalexception-or-systemexit-is-reported-when-a-process-or-rake-task-exits |
When I upgraded the gem from
3.3
->4.2.1
SignalExceptions disappeared from my Puma processes (this is good). However they still remain in my long running rake tasks (this is bad).I see in https://github.com/honeybadger-io/honeybadger-ruby/pull/269/files that SignalException is squashed in the
at_exit
callback. Is there something different about howinstall_at_exit_callbacks
works for Rake?The rake tasks are being invoked inside a container and managed by
supervisord
which invokesbundle exec rake myraketask
. When the container is killed (after a deploy) the container sends SIGTERM which causes Ruby to raiseSignalException
. As per #269 this should be ignored.Any thoughts?
The text was updated successfully, but these errors were encountered: