Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade setuptools to fix CI #50734

Merged
merged 2 commits into from May 17, 2021
Merged

Downgrade setuptools to fix CI #50734

merged 2 commits into from May 17, 2021

Conversation

KapJI
Copy link
Member

@KapJI KapJI commented May 16, 2021

Proposed change

It seems pypa/setuptools#2640 in setuptools 56.2.0 broke installation for some packages. Use older version as a workaround.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added bugfix small-pr PRs with less than 30 lines. labels May 16, 2021
@project-bot project-bot bot added this to Needs review in Dev May 16, 2021
@KapJI
Copy link
Member Author

KapJI commented May 16, 2021

I think after Github Actions outage they flushed caches and this issue emerged.

@KapJI
Copy link
Member Author

KapJI commented May 16, 2021

Jinja2 was recently updated to version 3.0.0 which improved typing support, to fix mypy we need to remove some redundant stuff.

@KapJI
Copy link
Member Author

KapJI commented May 16, 2021

No idea how codecov was triggered on files which I didn't touch.

@janiversen
Copy link
Member

I suppose it is because it run over all files as defined in the ini file.

Apart from that, does setup tools use freesms ? (CI breaks down in freesms==0..1.2)

@cdce8p
Copy link
Member

cdce8p commented May 16, 2021

Apart from that, does setup tools use freesms ? (CI breaks down in freesms==0..1.2)

@janiversen No, setuptools doesn't. However we install it as part of the CI job for later tests and the install itself fails. The reason is that it has an ill-formatted license field. bfontaine/freesms#7 will fix that, but freesms might not be the only package that is failing.

@janiversen
Copy link
Member

thanks for the explanation, looking forward to this PR being merged, so we can get CI operational again.

@balloob balloob merged commit 6b38ada into home-assistant:dev May 17, 2021
Dev automation moved this from Needs review to Done May 17, 2021
@KapJI KapJI deleted the fix-ci branch May 17, 2021 08:52
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

CI is broken because of setuptools
5 participants