Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable free-mobile because requirement breaks setuptools #50749

Merged
merged 5 commits into from May 17, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented May 17, 2021

Breaking change

free_mobile has been disabled because its dependency is not compatible with modern setup tools.

Proposed change

The free_mobile integration depends on free_sms Python package which is incompatible with newer versions of setuptools: bfontaine/freesms#7

This PR disables the free_mobile integration to allow us to use modern versions of setuptools.

This PR includes a partial revert of pinning setuptools added in #50734

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev May 17, 2021
Dev automation moved this from Needs review to Reviewer approved May 17, 2021
@frenck frenck merged commit 1b74359 into dev May 17, 2021
Dev automation moved this from Reviewer approved to Done May 17, 2021
@frenck frenck deleted the disable-free-mobile branch May 17, 2021 06:12
@bfontaine
Copy link

Hello, FYI free_sms 0.2.0 is out with fixed code thanks to @cdce8p.

@thecode thecode mentioned this pull request May 17, 2021
21 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants