Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Upgrades #16531

Merged
merged 8 commits into from Nov 5, 2021
Merged

Tools: Upgrades #16531

merged 8 commits into from Nov 5, 2021

Conversation

bre1470
Copy link
Contributor

@bre1470 bre1470 commented Oct 23, 2021 •
edited

  • Upgraded ESLint.
  • Upgraded ESLint JSDoc.
  • Upgraded ESLint TypeScript.
  • Updated API documentation generators.
  • Updated BS browsers for karma.
  • Redeactivated JSDoc validation in samples.
  • Restored IE8 tests for CircleCI.

@bre1470 bre1470 self-assigned this Oct 23, 2021
@highsoft-bot highsoft-bot added this to Review in progress in Development-Flow via automation Oct 23, 2021
@highsoft-bot highsoft-bot moved this from Review in progress to In progress in Development-Flow Oct 23, 2021
@bre1470 bre1470 marked this pull request as ready for review October 23, 2021 16:14
@highsoft-bot highsoft-bot moved this from In progress to Review in progress in Development-Flow Oct 23, 2021
@bre1470 bre1470 marked this pull request as draft October 23, 2021 19:37
@highsoft-bot highsoft-bot moved this from Review in progress to In progress in Development-Flow Oct 23, 2021
@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Oct 25, 2021 •
edited

File size comparison

No differences found

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Oct 25, 2021 •
edited

Visual test results - No difference found

@bre1470 bre1470 closed this Oct 26, 2021
Development-Flow automation moved this from In progress to Done Oct 26, 2021
@bre1470 bre1470 deleted the tools/upgrades branch October 26, 2021 09:52
@bre1470 bre1470 restored the tools/upgrades branch October 28, 2021 06:53
@bre1470 bre1470 reopened this Oct 28, 2021
@highsoft-bot highsoft-bot moved this from Done to In progress in Development-Flow Oct 29, 2021
@bre1470 bre1470 force-pushed the tools/upgrades branch 4 times, most recently from 43a5cbb to 1304494 Compare October 29, 2021 09:48
@bre1470 bre1470 force-pushed the tools/upgrades branch 4 times, most recently from f0b3a7e to 41780b7 Compare November 2, 2021 17:15
@bre1470 bre1470 closed this Nov 2, 2021
Development-Flow automation moved this from In progress to Done Nov 2, 2021
@bre1470 bre1470 reopened this Nov 2, 2021
@bre1470 bre1470 marked this pull request as ready for review November 2, 2021 19:25
@highsoft-bot highsoft-bot moved this from Done to Review in progress in Development-Flow Nov 2, 2021
@bre1470
Copy link
Contributor Author

bre1470 commented Nov 3, 2021

@TorsteinHonsi Ready for merge. ESLint upgrade only contains the latest default rules, but the new JSDoc plugin had some impact on the sources as you will notice. Use of the new ESLint rules and autofix goes in an other PR.

TorsteinHonsi
TorsteinHonsi approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@TorsteinHonsi TorsteinHonsi merged commit 33075df into master Nov 5, 2021
Development-Flow automation moved this from Review in progress to Done Nov 5, 2021
@TorsteinHonsi TorsteinHonsi deleted the tools/upgrades branch November 5, 2021 12:48
@highsoft-bot highsoft-bot added this to the Next milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

Assignees

@bre1470 bre1470

Labels
None yet
Projects
Development-Flow
  
Done
Milestone
v9.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bre1470 @highsoft-bot @TorsteinHonsi