Merge pull request #16531 from highcharts/tools/upgrades

Tools: Upgrades

.circleci/config.yml

@@ -518,13 +518,13 @@ workflows:
           browsers: "ChromeHeadless --tests highcharts/*/*,maps/*/*,stock/*/*,gantt/*/*"
           browsercount: 2
           requires: [lint]
-      # - test_browsers:
-      #     name: "test-Win.IE8"
-      #     requires: [lint]
-      #     browsers: "Win.IE8 --oldie"
+      - test_browsers:
+          name: "test-Win.IE8"
+          requires: [lint]
+          browsers: "Win.IE8 --oldie"
       - test_browsers:
           name: "test-Mac.Safari"
-          requires: ["lint", "generate_ts_declarations"]
+          requires: ["test-Win.IE8", "generate_ts_declarations"]
           browsers: "Mac.Safari"
       - test_browsers:
           name: "test-Mac.Firefox"

.eslintrc

@@ -1,31 +1,61 @@
-extends:
-    "./node_modules/eslint-config-eslint/default.yml"
-
-rules:
-    camelcase: [2, {"properties": "always"}]
-    comma-dangle: [2, "never"]
-    dot-location: [2, "property"]
-    lines-around-comment: 0
-    max-len: 2
-    newline-after-var: 0
-    no-alert: 2
-    no-console: 2
-    no-debugger: 2
-    no-else-return: 2
-    no-nested-ternary: 0
-    no-param-reassign: 0 // Would be useful, but takes some work
-    no-restricted-properties: 0 // Complains about .substr and .substring. Not yet.
-    no-unmodified-loop-condition: 0
-    no-useless-escape: 0 // @todo: Useful but a bit risky to change. 54 errors.
-    no-var: 0 // Not yet
-    object-curly-spacing: [2, "always"]
-    operator-assignment: 0 // Could be nice, but the change is somewhat error prone.
-    operator-linebreak: [2, "after"]
-    padding-line-between-statements: 0 // Annoying in samples and tools. If we want it, do --fix.
-    prefer-arrow-callback: 0 // Not supported in Highcharts, too early for tests and samples.
-    prefer-spread: 0 // Too early for samples
-    prefer-template: 0 // Will probably create a lot of noise in samples
-    space-before-function-paren: [2, {"anonymous": "always", "named": "never"}] # JSLint style
-    strict: 0
-    valid-jsdoc: ["error", { prefer: { "returns": "return"}}]
-    quotes: [2, "single"]
+{
+    "extends": "./node_modules/eslint-config-eslint/default.yml",
+    "rules": {
+        "camelcase": [2, {"properties": "always"}],
+        "comma-dangle": [2, "never"],
+        "dot-location": [2, "property"],
+        "lines-around-comment": 0,
+        "max-len": 2,
+        "newline-after-var": 0,
+        "no-alert": 2,
+        "no-console": 2,
+        "no-debugger": 2,
+        "no-else-return": 2,
+        "no-nested-ternary": 0,
+        "no-param-reassign": 0, // Would be useful, but takes some work
+        "no-restricted-properties": 0, // Complains about .substr and .substring. Not yet.
+        "no-unmodified-loop-condition": 0,
+        "no-unused-vars": 1,
+        "no-useless-escape": 0, // @todo: Useful but a bit risky to change. 54 errors.
+        "no-var": 0, // Not yet
+        "object-curly-spacing": [2, "always"],
+        "operator-assignment": 0, // Could be nice, but the change is somewhat error prone.
+        "operator-linebreak": [2, "after"],
+        "quotes": [2, "single"],
+        "padding-line-between-statements": 0, // Annoying in samples and tools. If we want it, do --fix.
+        "prefer-arrow-callback": 0, // Not supported in Highcharts, too early for tests and samples.
+        "prefer-spread": 0, // Too early for samples
+        "prefer-template": 0, // Will probably create a lot of noise in samples
+        "require-unicode-regexp": 1,
+        "space-before-function-paren": [2, {"anonymous": "always", "named": "never"}], // JSLint style
+        "strict": 0,
+        "jsdoc/check-alignment": 1,
+        "jsdoc/check-param-names": 1,
+        "jsdoc/newline-after-description": 0,
+        "jsdoc/require-jsdoc": 0,
+        "jsdoc/require-param": 1,
+        "jsdoc/require-returns": 0
+    },
+    "settings": {
+        "jsdoc": {
+            "preferredTypes": {
+                "array": "Array",
+                "function": "Function",
+                "object": "Object",
+                "Boolean": "boolean",
+                "Number": "number",
+                "Object": "Object",
+                "String": "string"
+            },
+            "tagNamePreference": {
+                "augments": "augments",
+                "class": "class",
+                "constructor": "class",
+                "emits": "emits",
+                "extends": "extends",
+                "fires": "emits",
+                "returns": "return"
+            }
+        }
+    }
+}

changelog/generate.js

@@ -46,7 +46,7 @@ const getFile = url => new Promise((resolve, reject) => {
         path = require('path'),
         tree = require('../tree.json');
 
-    /*
+    /**
      * Return a list of options so that we can auto-link option references in
      * the changelog.
      */