Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore ansi_term advisory #1769

Merged
merged 3 commits into from Aug 24, 2022
Merged

Ignore ansi_term advisory #1769

merged 3 commits into from Aug 24, 2022

Conversation

nhurley3
Copy link
Contributor

@nhurley3 nhurley3 mentioned this pull request Aug 23, 2022
Merged
bluejekyll
bluejekyll approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I just merged this: #1768, I think this is actually a more elegant fix.

Would you care to revert the Makefile.toml change I made in #1768? And keep your change here?

@nhurley3
Copy link
Contributor Author

Would you care to revert the Makefile.toml change I made in #1768? And keep your change here?

Done. Reverted the Makefile.toml change here.

@bluejekyll
Copy link
Member

Thanks for the PR!

@bluejekyll bluejekyll merged commit 82f47e8 into hickory-dns:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhurley3 @bluejekyll @djc