Add option to use a provided name server order #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to the "on/off" switch discussed in hickory-dns#1702. A later pull request will make improvements to the "Default" strategy.
This corresponds to the "on/off" switch discussed in hickory-dns#1702. A later pull request will make improvements to the "Default" strategy.
djc
reviewed
Aug 20, 2022
|
Failing CI is due to tokio-rs/tracing#2282, so we can ignore that here. |
djc
approved these changes
Aug 23, 2022
|
LGTM, but I'm not allowed to merge this due to strict merge conditions. |
Thanks! Any action needed from me or do we just need @bluejekyll to merge? |
|
No action from you needed! |
|
Though for now it might make sense to add the ansi_term advisory to the |
|
Mailed a separate PR for the ansi_term advisory. It looks like the underlying command is |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to the "on/off" switch discussed in #1702. A later pull
request will make improvements to the "Default" strategy.