Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: remove pytest and online testing mode #659

Merged
merged 2 commits into from Oct 20, 2022
Merged

Cleanup: remove pytest and online testing mode #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6c9b67
Remove pytest dependency
jayaddison Oct 19, 2022
ec969cf
Remove online testing functionality
jayaddison Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion requirements-dev.txt
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@ coverage>=4.5.1
flake8>=3.8.3
flake8-printf-formatting>=1.1.0
pre-commit>=2.6.0
pytest>=6.1.1
responses>=0.21.0
unittest-parallel>=1.5.0
mypy>=0.971
Expand Down
5 changes: 1 addition & 4 deletions tests/__init__.py
View file
Open in desktop
Expand Up @@ -8,7 +8,6 @@
class ScraperTest(unittest.TestCase):

maxDiff = None
online = False
test_file_name: Optional[str] = None
test_file_extension = "testhtml"
scraper_class: Any
Expand All @@ -33,8 +32,6 @@ def setUp(self):
for method, url, path in self.expected_requests:
start_url = start_url or url
with open(path, encoding="utf-8") as f:
response = responses.Response(method, url, body=f.read())
response.passthrough = self.online
rsps.add(response)
rsps.add(method, url, body=f.read())

self.harvester_class = self.scraper_class(url=start_url)
23 changes: 0 additions & 23 deletions tests/conftest.py
View file
Open in desktop

This file was deleted.