Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: remove pytest and online testing mode #659

Merged
merged 2 commits into from Oct 20, 2022

Commits on Oct 19, 2022

  1. Remove pytest dependency

    jayaddison committed Oct 19, 2022
    Copy the full SHA
    f6c9b67 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Remove online testing functionality

    It turns out that 'online' mode is kinda broken at the moment in the library - that's my fault for introducing it without ongoing testing.  In particular, the 'passthrough' flag -- by-design in 'responses' -- functions on in individual HTTP requests.  So, if an online request is redirected by the server, then -- without further configuration -- responses won't match the subsequent request to the redirected URL.
    
    Although some workarounds are possible, I think this feature needs a redesign.  It would be brilliant to support and improve near-current-data testing against various sites without sending them repeat/spammy request traffic.  'responses' has introduced a beta recording feature, and also VCR.py is available.
    jayaddison committed Oct 20, 2022
    Copy the full SHA
    ec969cf View commit details
    Browse the repository at this point in the history