Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed reishunger.de parser #352 #616

Merged
merged 11 commits into from Oct 12, 2022
Merged

fixed reishunger.de parser #352 #616

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6c788a1
fixed reishunger.de parser
vabene1111 Oct 1, 2022
0db180a
simplified code change
vabene1111 Oct 1, 2022
0a4c19c
assertEqulity for tests
vabene1111 Oct 2, 2022
51f53e3
changed loop iterator variable name
vabene1111 Oct 4, 2022
2c1f4ef
reishunger: identify recipe steps (schritt) and create one instructio…
jayaddison Oct 5, 2022
c0314d3
Fixup: why didn't I use normalize_string originally? :)
jayaddison Oct 5, 2022
16e78fc
Fixup: use 'findAll' instead of 'find' during retrieval of preparatio…
jayaddison Oct 6, 2022
97298d4
Update test expectations
jayaddison Oct 12, 2022
eaf05d0
reishunger: skip low-information instructions that contain only the t…
jayaddison Oct 12, 2022
ef43697
Merge branch 'main' into feature/reishunger-instructions
jayaddison Oct 12, 2022
6befc1d
Refactor: remove use of 'while' loop
jayaddison Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 8 additions & 10 deletions recipe_scrapers/reishunger.py
View file
Open in desktop
@@ -1,6 +1,6 @@
# mypy: disallow_untyped_defs=False

from ._abstract import AbstractScraper
from ._utils import normalize_string


class Reishunger(AbstractScraper):
Expand All @@ -27,17 +27,15 @@ def ingredients(self):
return self.schema.ingredients()

def instructions(self):
result = self.soup.find("section", {"class": "recipe-preparation"})
if result:
result = "\n".join(
normalize_string(i.get_text()) for i in result.findAll("p")
)
return result
elements = self.soup.findAll("div", {"class": "flex flex-col"})

# for recipes that do NOT allow to switch between different cooking methods
for e in elements:
if "Zubereitung" in e.get_text():
return e.get_text().replace("\xa0", " ")
jayaddison marked this conversation as resolved.
Show resolved Hide resolved

def ratings(self):
block = self.soup.find("div", {"id": "recipe-header"}).find(
"div", {"class": "nrating"}
)
block = self.soup.find("div", {"class": "nrating"})
if block:
cnt = len(block.findAll("span", {"class": "fa-star"}))
return cnt
Expand Down