fixed reishunger.de parser #352

recipe_scrapers/reishunger.py

@@ -1,4 +1,5 @@
 # mypy: disallow_untyped_defs=False
+
 from ._abstract import AbstractScraper
 from ._utils import normalize_string
 
@@ -27,17 +28,47 @@ def ingredients(self):
         return self.schema.ingredients()
 
     def instructions(self):
-        result = self.soup.find("section", {"class": "recipe-preparation"})
-        if result:
-            result = "\n".join(
-                normalize_string(i.get_text()) for i in result.findAll("p")
-            )
-        return result
+        # find the "instructions" heading (Zubereitung in German)
+        for heading in self.soup.findAll("h3"):
+            if "Zubereitung" in heading.get_text():
+                break
+
+        results = []
+
+        # locate the first recipe instruction
+        step1 = heading.parent.parent.find("div", {"class": "leading-normal"})
+
+        # iterate through each step in the recipe
+        for step in step1.next_siblings:
+
+            # check whether the instruction has a list of preparations
+            # fixme: this can throw an exception if 'step' is not a bs4 Tag
+            try:
+                preparations = step.find("div", {"preparation": True})
+            except Exception:
+                preparations = None
+
+            # if it does, add every preparation step as an instruction entry
+            if preparations:
+                for preparation in preparations.findAll("div", {"id": True}):
+                    instruction = normalize_string(preparation.text)
+                    results.append(instruction)
+
+            # otherwise, add only one instruction entry
+            else:
+                if step.find("p"):
+                    instruction = normalize_string(step.text)
+                    results.append(instruction)
+
+            # continue on to the next instruction
+            step = step.next_sibling
+
+        # filter out empty lines
+        results = [instruction for instruction in results if instruction]
+        return "\n".join(results)
 
     def ratings(self):
-        block = self.soup.find("div", {"id": "recipe-header"}).find(
-            "div", {"class": "nrating"}
-        )
+        block = self.soup.find("div", {"class": "nrating"})
         if block:
             cnt = len(block.findAll("span", {"class": "fa-star"}))
             return cnt