Cleanup: remove pytest and online testing mode #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that 'online' mode is kinda broken at the moment in the library - that's my fault for introducing it without ongoing testing. In particular, the 'passthrough' flag -- by-design in 'responses' -- functions on in individual HTTP requests. So, if an online request is redirected by the server, then -- without further configuration -- responses won't match the subsequent request to the redirected URL. Although some workarounds are possible, I think this feature needs a redesign. It would be brilliant to support and improve near-current-data testing against various sites without sending them repeat/spammy request traffic. 'responses' has introduced a beta recording feature, and also VCR.py is available.
|
@hhursev @bfcarpio @astappiev does this approach seem OK to you? I had -- still have -- grand plans for online testing (I think it'd be brilliant if we could keep up-to-date with recent website changes while minimizing request traffic and also adding a kind of safety-check to ensure site data is public) -- but I don't think the feature as-implemented was helping towards that, and until then it's probably better to remove it. |
|
Perhaps it's brash, but I'm going to move ahead with this as-is. It's pure dependency/feature removal, and for a feature that already seems partially broken. Please feel free to disagree and I'll take another look. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only use case for
pytestin the codebase was for online scraper testing, and this wasn't a feature that we had tested since it was introduced.In combination with the
responseslibrary, it doesn't currently function particularly well for any site that performs HTTP redirects. There are ways to workaround that, but I think that online testing requires a more thorough design and integration with CI if we're to offer it as a well-supported feature.Until then, this pull request suggests removing
pytestand the online testing functionality.Relates to #617.