New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround: install lxml from binary wheel when unit tests run on MacOS #629
Conversation
eaed1ba
to
b72e186
Compare
b72e186
to
195d86d
Compare
195d86d
to
3655803
Compare
799acbd
to
dbea462
Compare
My guess is that this isn't a runtime issue; I think something's wrong with the
...and yet
|
…ation from unittest matrix" This reverts commit bdf58c5.
…in combination with macos-11 (20221002.2) runner
4e9e7a8
to
de3e786
Compare
It seems that there is a behaviour change between (one of the versions of?) The binary wheel on PyPi -- which was statically compiled once and then uploaded for distribution -- appears to work. So we can use Why doesn't this affect other versions of Python during unit testing? I'm unsure. |
Also now noted in the pull request description, but for context here too: the reason that this only appeared to affect Python 3.10 and Python 3.11-rc.1 on MacOS was that binary wheels of So in fact, there wasn't necessarily a behaviour change introduced by either MacOS or Python. |
A pull request to attempt to narrow down on the version of Python 3.10.x where MacOS unit test failure noted at #628 (comment) bug could have been introduced.Reading and comparing the 3.10.x and 3.11.x changelogs (since the failure affects both lineages) hasn't produced any definitive answers yet.Problem identified: when
lxml
is installed from source on MacOS, it will link against the system-providedlibxml2
at build-time. This appears to be the cause of the unit test failures we noticed, and this does not occur when using binary wheels from PyPy.As a workaround, ensure that
lxml
is installed from binary wheel during MacOS unit test runs.