Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround: install lxml from binary wheel when unit tests run on MacOS #629

Merged
merged 15 commits into from Oct 12, 2022
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8c3bc03
Revert "GitHub Actions: exclude {os:macos-latest, python:3.10} combin…
jayaddison Oct 10, 2022
de3e786
GitHub Actions unit tests: add workaround for setup.py-compiled lxml …
jayaddison Oct 10, 2022
82e0e5e
YAML fixup: ensure that step name is interpreted as a string
jayaddison Oct 10, 2022
2614a68
GitHub Actions syntax fixup: add missing 'matrix' namespace to variab…
jayaddison Oct 10, 2022
51892a3
revertme: gather a little more diagnostic information about the natur…
jayaddison Oct 11, 2022
651d0ca
revertme: fixup: add encoding parameter during diagnostic HTML parsing
jayaddison Oct 11, 2022
5b501aa
revertme: fixup: use py3.10 during HTML parsing diagnostics collection
jayaddison Oct 11, 2022
c8c03d4
revertme: print length of parsed HTML root node text contents as diag…
jayaddison Oct 11, 2022
fb38799
Revert "revertme: print length of parsed HTML root node text contents…
jayaddison Oct 11, 2022
7751c4d
Revert "revertme: fixup: use py3.10 during HTML parsing diagnostics c…
jayaddison Oct 11, 2022
ecd261e
Revert "revertme: fixup: add encoding parameter during diagnostic HTM…
jayaddison Oct 11, 2022
ad3721a
Revert "revertme: gather a little more diagnostic information about t…
jayaddison Oct 11, 2022
a3dbf94
Use binary wheel for lxml during all MacOS platform unit test runs
jayaddison Oct 12, 2022
ac0067e
Revert "Use binary wheel for lxml during all MacOS platform unit test…
jayaddison Oct 12, 2022
c21be72
Use binary wheel for lxml during all MacOS platform unit test runs
jayaddison Oct 12, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/unittests.yaml
Expand Up @@ -15,19 +15,25 @@ jobs:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11.0-rc.1"]
exclude:
- os: macos-latest
python-version: "3.10"
- os: macos-latest
python-version: "3.11.0-rc.1"
- os: windows-latest
python-version: "3.11.0-rc.1"
include:
- os: macos-latest
python-version: "3.10"
jayaddison marked this conversation as resolved.
Show resolved Hide resolved
lxml-binary-wheel-workaround: true
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
# 2022-10-10: setup.py-compiled lxml fails to parse test_wild_mode.testhtml on macos-11 (20221002.2) runner
- name: "Workaround: force installation of binary wheel variant of lxml"
if: ${{ matrix.lxml-binary-wheel-workaround }}
run: pip install --only-binary=lxml lxml
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down